From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastien Vauban Subject: Re: 63 failures for org-test-run-all-tests in an Emacs GUI Date: Wed, 31 Dec 2014 10:25:30 +0100 Message-ID: <86bnmk892t.fsf@example.com> References: <86zjaf7knu.fsf@example.com> <87ioh12x25.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org To: emacs-orgmode-mXXj517/zsQ@public.gmane.org Hello Nicolas, Nicolas Goaziou wrote: > Sebastien Vauban writes: > >> I just ran `org-test-run-all-tests' in my active WinNT Emacs session >> (with Org-mode release_8.3beta-677-g0497e3), and was surprised by the >> high number of failures: > > You probably heavily customized Org, and many tests expect default > values for defcustoms to run properly. > > I fixed the most obvious one, but there is more work to do in that area. Did I misunderstand the change of last year (Dec '13) or should `sh' language be abandoned in favor of `shell'? IIUC, then, those blocks should be updated: --8<---------------cut here---------------start------------->8--- ./examples/babel.org:238:#+begin_src sh :tangle yes :noweb yes :shebang "#!/bin/sh" ./examples/babel.org:243:#+begin_src sh :noweb-ref fullest-disk ./examples/babel.org:248:#+begin_src sh :noweb-ref fullest-disk ./examples/babel.org:253:#+begin_src sh :noweb-ref fullest-disk ./examples/babel.org:258:#+begin_src sh :noweb-ref fullest-disk ./examples/babel.org:315:#+begin_src sh :foo "baz" ./examples/babel.org:327:#+BEGIN_SRC sh :exports none ./examples/babel.org:333:#+BEGIN_SRC sh :noweb no-export :exports both ./examples/babel.org:376:#+BEGIN_SRC sh :exports none ./examples/babel.org:380:#+BEGIN_SRC sh :noweb strip-export :exports code :results silent ./examples/babel.org:447:#+BEGIN_SRC sh :shebang #!/bin/sh :exports results :results verbatim ./examples/ob-shell-test.org:25:#+begin_src sh :exports results :var array=sample_array ./examples/ob-shell-test.org:50:#+begin_src sh :exports results :var table=sample_mapping_table ./examples/ob-shell-test.org:72:#+begin_src sh :exports results :var table=sample_big_table ./lisp/test-ob.el:471:#+begin_src sh :results scalar ./lisp/test-ob.el:478:#+begin_src sh :results raw scalar ./lisp/test-ob.el:509: (org-test-with-temp-text "#+begin_src sh\necho Hello\n#+end_src\n" ./lisp/test-ob.el:669: (org-test-with-temp-text "#+begin_src sh :results output :tangle yes ./lisp/test-ob.el:674:#+begin_src sh ./lisp/test-ob.el:680: (org-test-with-temp-text "#+begin_src sh :results output :tangle yes ./lisp/test-ob.el:685:#+begin_src sh :noweb-sep \"\" ./lisp/test-ob.el:689:#+begin_src sh :noweb-ref foo :noweb-sep \"\" ./lisp/test-ob.el:812: #+begin_src sh :results file wrap ./lisp/test-ob.el:1140:#+begin_src sh :var data=input-table :exports results :colnames '(Rev Author) ./lisp/test-ob.el:1158:#+begin_src sh :var data=input-table :exports results :colnames '(Rev Author) ./README:20:#+BEGIN_SRC sh :dir (expand-file-name "..") --8<---------------cut here---------------end--------------->8--- And those inline calls as well: --8<---------------cut here---------------start------------->8--- ./examples/babel.org:199:Here is one in the middle src_sh{echo 1} of a line. ./examples/babel.org:200:Here is one at the end of a line. src_sh{echo 2} ./examples/babel.org:201:src_sh{echo 3} Here is one at the beginning of a line. ./examples/babel.org:209:Here is one in the middle src_sh{echo 1} of a line. ./examples/babel.org:210:Here is one at the end of a line. src_sh{echo 2} ./examples/babel.org:211:src_sh{echo 3} Here is one at the beginning of a line. ./examples/babel.org:212:Here is one that is also evaluated: src_sh[:exports both]{echo 4} ./examples/babel.org:293:src_sh{echo "One"} block at start of line ./examples/babel.org:294: One spaced block in src_sh{ echo "middle" } of line ./examples/babel.org:295:src_sh{echo 2} blocks on the src_emacs-lisp{"same"} line ./examples/babel.org:296: Inline block with src_sh[:results silent]{ echo "parameters" }. ./examples/babel.org:303:src_sh[]{echo "One"} block at start of line ./examples/babel.org:304: One spaced block in src_sh[]{ echo "middle" } of line ./examples/babel.org:305:src_sh[]{echo 2} blocks on the src_emacs-lisp[]{"same"} line ./examples/babel.org:306: Inline block with src_sh[:results silent]{ echo "parameters" }. ./lisp/test-ob-exp.el:242: "\\\\\\[]{" "\\(?:\\[]\\)?{" ;accept both src_sh[]{...} or src_sh{...} ./lisp/test-ob-exp.el:243: (regexp-quote "Here is one in the middle src_sh[]{echo 1} of a line. ./lisp/test-ob-exp.el:244:Here is one at the end of a line. src_sh[]{echo 2} ./lisp/test-ob-exp.el:245:src_sh[]{echo 3} Here is one at the beginning of a line. ./lisp/test-ob-exp.el:246:Here is one that is also evaluated: src_sh[]{echo 4} =4=") ./lisp/test-ob.el:297: (let ((test-line "src_sh{echo 1}")) --8<---------------cut here---------------end--------------->8--- I am willing to make the patch. Best regards, Seb -- Sebastien Vauban