From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UO4qHpn68mKJhQEAbAwnHQ (envelope-from ) for ; Wed, 10 Aug 2022 02:23:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OGztHZn68mIeXAAAauVa8A (envelope-from ) for ; Wed, 10 Aug 2022 02:23:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2EAA144837 for ; Wed, 10 Aug 2022 02:23:53 +0200 (CEST) Received: from localhost ([::1]:59090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLZVn-0005Vc-Vr for larch@yhetil.org; Tue, 09 Aug 2022 20:23:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLZVC-0005Rp-8Y for emacs-orgmode@gnu.org; Tue, 09 Aug 2022 20:23:14 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:40700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLZVA-00017n-AN for emacs-orgmode@gnu.org; Tue, 09 Aug 2022 20:23:13 -0400 Received: by mail-pj1-x102f.google.com with SMTP id s5-20020a17090a13c500b001f4da9ffe5fso526651pjf.5 for ; Tue, 09 Aug 2022 17:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc; bh=Ln6wpg6RwrCo6zg7wqR5xSl6yBIlfczOmiC2ntj7ujo=; b=XEN9Rbg51RPvHfe8oOiBVv2S58QB7eAw+Qv+One4538DoWkqkRz646orNm4RVWLzQL Vm75L1R9WUjP6C7/OuBcmwSf41+cgfrIVZI9oUz0ryjrNDxxDlqrhZzSPDiarQHVfInj Thy96pJnF3FhMEfSe8CvcXDVS7dRBg/J+Ll8CNf/ueL+kUTc6izCoTYaAwz1p1kVF/8n MH7HuO2GtOtfBs98qECquPjs40DRuvhHowFLzEelNabIEVPmDRlTM0pbQMhylKDovafh 0jLmfgCMKj86FDnDbVIQkHeUza4bFtN1b3SprkriwrM2WYwMR7zdWhBzquRYAdAUQvUN kOdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc; bh=Ln6wpg6RwrCo6zg7wqR5xSl6yBIlfczOmiC2ntj7ujo=; b=W8foXw/FaWhtZgySfdreDSGzbWBYzO7CL3XsPfGDvaVkf7tGBXxiLvm8zMXiLEDQlM dIzFucs+N5CmjTfLc3ruoNZ9XthPm8ZAGgfdFCUaTiwxpiYblSJOxz3W+YMuNNzkuzvg +ZOp4LFbL89hCZVb/mqQ975SFjuXsmDg8fZuMemy1TS0an9xtK3JfeMqA+krBPKVG62G pTmcRPCKyYFH8/ewiOdMYKzqTG2exvixVdQeZjXtmzGHwf/7DmRSCzw/j0k3knMAsOyk x3Tz5Sp42fNgHEg1O4+0ZGt2T8MoOwGPXhetpfptefQbunXaiLUTvsxxQ3FF1mXUknf7 39sw== X-Gm-Message-State: ACgBeo3G3JXJg5lzTyS4M4Apum2NvfN/XOv/QsElJ3IH1vQiqtd8Eco2 A9Ikg/CX+CftA974j5U+UFEe3Z16tiM/rA== X-Google-Smtp-Source: AA6agR6x8RnsoiJQ/f+V4Qvlou2M0zxg2htk2nDK1dOaoVOCCVhU0v7IKwYE40uFTXfsUFhTSlStig== X-Received: by 2002:a17:902:d2c6:b0:16e:eeac:29bc with SMTP id n6-20020a170902d2c600b0016eeeac29bcmr25534406plc.76.1660090990184; Tue, 09 Aug 2022 17:23:10 -0700 (PDT) Received: from dingbat (2001-44b8-31f2-bb00-842a-7361-87c7-2662.static.ipv6.internode.on.net. [2001:44b8:31f2:bb00:842a:7361:87c7:2662]) by smtp.gmail.com with ESMTPSA id l18-20020a170903245200b0016dc307aef4sm11541192pls.36.2022.08.09.17.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 17:23:09 -0700 (PDT) References: <875ykikvaz.fsf@localhost> <87sfnlk0tj.fsf@localhost> <874jzg5bg7.fsf@gnu.org> <87les9l9wv.fsf@localhost> <87pmhad9gv.fsf@gnu.org> User-agent: mu4e 1.8.8; emacs 29.0.50 From: Tim Cross To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Delete some Emacs 24 compat code Date: Wed, 10 Aug 2022 10:06:04 +1000 In-reply-to: Message-ID: <868rnxgd5i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=theophilusx@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660091033; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Ln6wpg6RwrCo6zg7wqR5xSl6yBIlfczOmiC2ntj7ujo=; b=Ie7kSRjckTq6N23VjYLSISMkOeXQ4qy+zwpBoGxdOoOdm32KPoJRsQlTgrnG7kGXd7xtsp qj8HmBg0levcSUODu6Ar2em/Amgj3phgS8K4abp9/kRYq1r8umshSzwOzEX3j3M5sml6TA CaUIUuwpWlktVIFJJRdzpM6YfulzsvF7rDg7szarwVnGAP0LNAlVsFm/1FJ/JEukQa/Izt E4FCmSFDBgXpm5n4q+QQwUErVwuxw6p9XMiX+kdUgfms/3QnIUyRChyGLhdBAYYhOM2MCP TcjxMgWiaPGwF/peQ3lBu1GfftVo+j1tHckNlza7Wh/mqAR33AqOcZZ20f6nSg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660091033; a=rsa-sha256; cv=none; b=InJ9yjCJxBMHuaHPyj4h06sURrHVSH4+nVcM+GxyNBVvQL5XPOEFgGAJSdQTHP+eQkRwwY P/AgZoorXhMwIiYGhFHPBCnOzO6lHBwJsyohBRlHsl+RO2cTgF5XJjY0kQ9rsIDeng7U7e Q0z/gzu9aOjK3UHUsqiixvX+jFagF0swopcc7axKCy79x/P49DYsqFvre/MDg2IU2HEp5L Cgmw+M5VqqUmSDUsHj0Ml2HAfGkagGkAZvRkbfExHBF9+OUpoQMGkaZl83dflCt31G/713 /in3c3GYN/bnglTNq/Fi9C7qoh+2DXrLlIIXYXJYo5w3JSS0dN/sneFk1ag83w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XEN9Rbg5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.89 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XEN9Rbg5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2EAA144837 X-Spam-Score: -3.89 X-Migadu-Scanner: scn1.migadu.com X-TUID: CezLb6SHM1Ly Max Nikulin writes: > On 08/08/2022 22:46, Bastien wrote: >> Ihor Radchenko writes: >> >>> Could you please elaborate on how exactly we can determine if a >>> commit changes the compatibility status? >> Today, we are interested in knowing whether Org is compatible with >> Emacs 28.1, Emacs 27.1 and Emacs Emacs 26.1. > > Please, keep ";; Package-Requires: " version in org.el consistent with such statement > (Should it be updated for the bugfix branch as well?). > > Such commit may be accompanied by an announce sent to the mail list. Samuel may check this > declaration in his update script. > The above is good to do and your right, it is hard not to forget to do this. However, this is somewhat independent of whether there has been a commit which breaks compatibility with a version. This is something which should be updated when a new major version of Emacs is released. It really just states which version org is (should be) compatible with. It says little about which versions it actually is compatible with i.e. it might say Emacs versions 28.x, 27.x and 26.x, but that doesn't mean it isn't compatible with 25.x - it only says that if it doesn't work with 25.x, that is not considered a bug. . > The problem is that it is too easy to forget to make such change before committing of > something that really breaks compatibility. That is a problem, but the real problem is that you don't know you have broken compatibility because your likely no longer testing against that version. Sometimes you will and we should inform the community when we know, but we cannot guarantee we will always let the list know immediately when compatibility is lost for these no longer supported versions.