Re: [PATCH] Delete some Emacs 24 compat code

[Tim Cross <theophilusx@gmail.com>]

Max Nikulin <manikulin@gmail.com> writes:

> On 08/08/2022 22:46, Bastien wrote:
>> Ihor Radchenko writes:
>> 
>>> Could you please elaborate on how exactly we can determine if a
>>> commit changes the compatibility status?
>> Today, we are interested in knowing whether Org is compatible with
>> Emacs 28.1, Emacs 27.1 and Emacs Emacs 26.1.
>
> Please, keep ";; Package-Requires: " version in org.el consistent with such statement
> (Should it be updated for the bugfix branch as well?).
>
> Such commit may be accompanied by an announce sent to the mail list. Samuel may check this
> declaration in his update script.
>

The above is good to do and your right, it is hard not to forget to do
this. However, this is somewhat independent of whether there has been a
commit which breaks compatibility with a version. This is something
which should be updated when a new major version of Emacs is
released. It really just states which version org is (should be)
compatible with. It says little about which versions it actually is
compatible with i.e. it might say Emacs versions 28.x, 27.x and 26.x,
but that doesn't mean it isn't compatible with 25.x - it only says that
if it doesn't work with 25.x, that is not considered a bug. . 

> The problem is that it is too easy to forget to make such change before committing of
> something that really breaks compatibility.

That is a problem, but the real problem is that you don't know you have
broken compatibility because your likely no longer testing against that
version. Sometimes you will and we should inform the community when we
know, but we cannot guarantee we will always let the list know
immediately when compatibility is lost for these no longer supported
versions.