emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [docupatch] Prefix argument to exclude agenda items
@ 2015-09-09 14:56 Marco Wahl
  2015-09-10  8:40 ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Marco Wahl @ 2015-09-09 14:56 UTC (permalink / raw)
  To: emacs-orgmode

Hi!

I just found out by accident that a prefix argument to <
(org-agenda-filter-by-category) excludes the category of the item at
point from the agenda.  Looks like that feature did not make it into the
documentation.

Is the extension of the documentation below acceptable?

--8<---------------cut here---------------start------------->8---
Head:     2c8b039 maint Merge branch 'maint' of orgmode.org:org-mode into maint
Upstream: 2c8b039 origin/maint Merge branch 'maint' of orgmode.org:org-mode into maint
Tag:      release_8.3.1 (113)

Unstaged changes (1)
modified   doc/org.texi
@@ -8616,9 +8616,10 @@ selected.
 @vindex org-agenda-category-filter-preset
 
 Filter the current agenda view with respect to the category of the item at
-point.  Pressing @code{<} another time will remove this filter.  You can add
-a filter preset through the option @code{org-agenda-category-filter-preset}
-(see below.)
+point.  Pressing @code{<} another time will remove this filter.  When called
+with a prefix argument exclude the category of the item at point from the
+agenda.  You can add a filter preset through the option
+@code{org-agenda-category-filter-preset} (see below.)
--8<---------------cut here---------------end--------------->8---


Ciao,  Marco
-- 
GPG: 0x49010A040A3AE6F2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [docupatch] Prefix argument to exclude agenda items
  2015-09-09 14:56 [docupatch] Prefix argument to exclude agenda items Marco Wahl
@ 2015-09-10  8:40 ` Nicolas Goaziou
  2015-09-10 12:15   ` Marco Wahl
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2015-09-10  8:40 UTC (permalink / raw)
  To: Marco Wahl; +Cc: emacs-orgmode

Marco Wahl <marcowahlsoft@gmail.com> writes:

> I just found out by accident that a prefix argument to <
> (org-agenda-filter-by-category) excludes the category of the item at
> point from the agenda.  Looks like that feature did not make it into the
> documentation.
>
> Is the extension of the documentation below acceptable?
>
> Head:     2c8b039 maint Merge branch 'maint' of orgmode.org:org-mode into maint
> Upstream: 2c8b039 origin/maint Merge branch 'maint' of orgmode.org:org-mode into maint
> Tag:      release_8.3.1 (113)
>
> Unstaged changes (1)
> modified   doc/org.texi
> @@ -8616,9 +8616,10 @@ selected.
>  @vindex org-agenda-category-filter-preset
>  
>  Filter the current agenda view with respect to the category of the item at
> -point.  Pressing @code{<} another time will remove this filter.  You can add
> -a filter preset through the option @code{org-agenda-category-filter-preset}
> -(see below.)
> +point.  Pressing @code{<} another time will remove this filter.  When called
> +with a prefix argument exclude the category of the item at point from the
> +agenda.  You can add a filter preset through the option
> +@code{org-agenda-category-filter-preset} (see below.)

LGTM. Thank you.

Could you also update org-agenda-filter-by-category's docstring (you may
also want to change (and cat) into cat there) and send a patch with git
format-patch?

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [docupatch] Prefix argument to exclude agenda items
  2015-09-10  8:40 ` Nicolas Goaziou
@ 2015-09-10 12:15   ` Marco Wahl
  2015-09-10 12:18     ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Marco Wahl @ 2015-09-10 12:15 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

>> modified   doc/org.texi
>> @@ -8616,9 +8616,10 @@ selected.
>>  @vindex org-agenda-category-filter-preset
>>  
>>  Filter the current agenda view with respect to the category of the item at
>> -point.  Pressing @code{<} another time will remove this filter.  You can add
>> -a filter preset through the option @code{org-agenda-category-filter-preset}
>> -(see below.)
>> +point.  Pressing @code{<} another time will remove this filter.  When called
>> +with a prefix argument exclude the category of the item at point from the
>> +agenda.  You can add a filter preset through the option
>> +@code{org-agenda-category-filter-preset} (see below.)
>
> LGTM. Thank you.

Thanks for the feedback.

> Could you also update org-agenda-filter-by-category's docstring (you may
> also want to change (and cat) into cat there) and send a patch with git
> format-patch?

I applied the changes you suggested and directly committed to branch
maint (commits 0b71022 and a4375e8).


Bye,
-- 
Marco Wahl
GPG: 0x49010A040A3AE6F2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [docupatch] Prefix argument to exclude agenda items
  2015-09-10 12:15   ` Marco Wahl
@ 2015-09-10 12:18     ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2015-09-10 12:18 UTC (permalink / raw)
  To: Marco Wahl; +Cc: emacs-orgmode

Marco Wahl <marcowahlsoft@gmail.com> writes:

> I applied the changes you suggested and directly committed to branch
> maint (commits 0b71022 and a4375e8).

Thank you.

Regards,

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-10 12:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-09 14:56 [docupatch] Prefix argument to exclude agenda items Marco Wahl
2015-09-10  8:40 ` Nicolas Goaziou
2015-09-10 12:15   ` Marco Wahl
2015-09-10 12:18     ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).