emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: org-today broken
Date: Mon, 04 Feb 2019 12:10:56 +0100	[thread overview]
Message-ID: <84h8djbygv.fsf@gmail.com> (raw)
In-Reply-To: 874l9k4auv.fsf@kyleam.com

Hi Kyle,

>> Occasionally I like to bend time to see what the agenda would look like
>> if another day was current.  This can be achieved conveniently when
>> solely function "current-time" is the source for the current time.
>>
>> So I'm all for using the explicit calls to current-time instead of using
>> alternatve sources for the current time.
>
> Sorry for making your time travel harder :]

:[

> Emacs's c75f505dea6 argues for replacing current-time calls with nil
> where possible because "nil is a bit more efficient and should have less
> timing error".  But if there are any particular spots where you'd like
> to use current-time for the reasons you give above, please feel free to
> make those changes.  (There are already quite a few places where I've
> done this because we depend on overriding current-time in tests.)

Thanks for the clarification.

I think it's a not so great idea to build on an assumption about some
internal stuff, here concretely the expectation that the current time is
retrieved per call to `current-time' everywhere in Org.

If there shall be a time travel feature in Org this feature should be
made explicit, I think, which BTW could be ensured with suitable tests.

Possibly one could use external tools to get even more powerful
timetravel, as Marcin proposed IIRC.

So go ahead with every optimization you can find!


Best regards,  Marco

  reply	other threads:[~2019-02-04 11:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01  1:41 org-today broken Samuel Wales
2019-02-01  4:12 ` Kyle Meyer
2019-02-01 12:55   ` Marco Wahl
2019-02-01 13:23     ` Marcin Borkowski
2019-02-04  1:10     ` Kyle Meyer
2019-02-04 11:10       ` Marco Wahl [this message]
2019-02-04 23:38   ` Samuel Wales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84h8djbygv.fsf@gmail.com \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).