From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wD1YDqoWJWRrJgAASxT56A (envelope-from ) for ; Thu, 30 Mar 2023 06:57:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8K1KDaoWJWTZ4AAAG6o9tA (envelope-from ) for ; Thu, 30 Mar 2023 06:57:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8E54E3D1CB for ; Thu, 30 Mar 2023 06:57:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phkKj-0007nf-SD; Thu, 30 Mar 2023 00:56:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phkKh-0007m0-47 for emacs-orgmode@gnu.org; Thu, 30 Mar 2023 00:56:19 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phkKf-0001Hx-5e for emacs-orgmode@gnu.org; Thu, 30 Mar 2023 00:56:18 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 16FBB24018C for ; Thu, 30 Mar 2023 06:56:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1680152174; bh=0G0+I/bnhGNSbHIEUoteMV6pGzoCnLtC95j5OdGKOEQ=; h=Date:From:To:Cc:Subject:From; b=JtGlst897yOIHstqSMcGDtd2SE2Z16l+LcIKXYnGl9PkUesKI5PcawJajLTWvV/eO xNHJkQRr9m9ckKliKWq8OPpUT1X0vz28VYkAn3A4jPj6RID/Mls3j75Ln7fCTwmHw4 Yz7jtMxMUbFawfm+rdcv2emsrDp9F5WitWQ1AqCE3aRaJByjJwhNonVA64lAErjpnz kU6cqkRjVN7YPziiA893eSmKhwpvYseZUr2u9NqbfbVU/WtjtNhuv85fc+ElbeP7rn CbQ+ZODx8tDJIBoTOaEd/qWErgKKHIOwklO1jMyzVtQZKNbEz4dWSsGq0Rigw9ESG3 5/oJdSyxGfCDw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PnB2j26jZz6twm; Thu, 30 Mar 2023 06:56:13 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 30 Mar 2023 04:56:13 +0000 From: gerard.vermeulen@posteo.net To: Ihor Radchenko Cc: Emacs orgmode , dto@gnu.org, emacs-orgmode-bounces+gerard.vermeulen=posteo.net@gnu.org Subject: Re: [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank In-Reply-To: <87jzyzx59i.fsf@localhost> References: <480536eb12bf49144384f4b1a85d8bdf@posteo.net> <87jzyzx59i.fsf@localhost> Message-ID: <84fa5f2a1c95c06ad3eac4000f21bab5@posteo.net> Received-SPF: pass client-ip=185.67.36.65; envelope-from=gerard.vermeulen@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=JtGlst89; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680152234; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=LpL7k747DQQHBf29naBCr/0TwRK4V5WxVV9SRGCCxvQ=; b=Iq06ZjNojTqYAiVPU73DkMe4m46YDS7YYudnKi0eSB0OKCpbQmWBz2lMPWPyQjd1r+3IeS G58kQf4znr8EZ0S9hVyVsfS4IRK10hpZ5hPsgU3YnPRtE0aQ+eFCPmHlyIa2+84XMSE0fF n7e9PitiDdm2L+yCcZrkTniKLoRBX+s8JuxAYMsx3XM2GWxq0vmhq2OCRiQoesWQMcbdRC poo20Na4Vo7c8+UZpERDOb1eh7KXd/KZD7EHJ78Yr16CuQUDZgyqZ/qwO4UIC/WgBCyjnt E2Q/ySoeTKRTSUhGmNjfZUMsaS4JNaLP10+OR0z+UdEGGIFVCDOmMyCuripbdw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680152234; a=rsa-sha256; cv=none; b=OiLWFNfUSRWHaUhxoco9v5WNWrNm0faj+t0RVTTeetv0+k77BwWmmG4Rtdl1IZTqzJQxQs iKlZY97SLzMUR3iCiK343b+v/hZmfLY3kpvbteOdojm68oTWZhwCCPR719b0aSXpkqt3vf KbSf2xHtprU4j+WXYP9uv7Rd651eHTBETVnu2jHZTtujgh/ySKc8wLE40Kwjb1BpBLd1yK bd+92iYMzNy7NU+2EKlaQ2e/ouuyfcJ/aK6Nvkt88VlPy3AlJvVFzPMqGTHbuxZh/itG3l VLx48d2wIg5VwoN/Q/F8Fs1GP6QDc3fNalrOEtSwLoZRlgnqxXRmQSaGS8Qrhg== X-Migadu-Spam-Score: -5.23 X-Migadu-Scanner: scn1.migadu.com X-Migadu-Queue-Id: 8E54E3D1CB Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=JtGlst89; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Spam-Score: -5.23 X-TUID: x4PvzWRQEI2q On 29.03.2023 11:42, Ihor Radchenko wrote: > gerard.vermeulen@posteo.net writes: > >> The Emacs integrated development environments Slime and Sly >> communicate by means of similar RPC protocols with different server >> programs: Swank in case of Slime and Slynk in case of Sly. However, >> the code in org-babel-execute:lisp always expects to talk with Swank >> because of the hard-coded call to swank:eval-and-grab-output. >> >> After starting a Sly REPL, calls to swank:eval-and-grab-output do not >> talk with the Slynk server started by the Sly REPL. >> >> The attached patch "soft-codes" eval-and-grab-output to become >> swank:eval-and-grab-output when using Slime and >> slynk:eval-and-grab-output when using Sly. > > I do not use ob-lisp, but this patch looks reasonable. > > I'd appreciate if other ob-lisp users could test the patch with both > SLY > and SLIME. > > I have no comments on the Elisp part of the patch. I have a few additional remarks: The patch is against main only because it overlaps a region where bugfix and main diverged. I am willing to provide a similar patch against main. I have installed Slime and Sly with the same user-emacs-directory using package-install. Normally, both autoload when doing M-x sly, but Sly prompts you whether you want to disable Slime. I choose "yes" to test Sly. I package-delete Sly when I want to test Slime. See https://github.com/joaotavora/sly/blob/master/CONTRIBUTING.md describes in detail how Sly uses the RPC protocol. I hope that my mail reaches David (CC-ed dto@gnu.org taken from the file header), but my previous message bounced (non-existent address). Best regards -- Gerard