emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org: Liberate org-property-action
Date: Thu, 23 Mar 2017 00:47:03 +0100	[thread overview]
Message-ID: <84d1d8ho20.fsf@tm6592> (raw)

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi!

This is a simple suggestion to improve function `org-property-action'.
Currently `org-property-action' errors when 'not at a property'.  But
this is unnecessary AFAICS.

Without the restriction one can use the function to control any property
inclusive setting the very first property.

Do I miss something (again)?


Best regards
            Marco



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-Liberate-org-property-action.patch --]
[-- Type: text/x-diff, Size: 826 bytes --]

From 83805606e630caf1ac47d0662b1e58df01441e3c Mon Sep 17 00:00:00 2001
From: Marco Wahl <marcowahlsoft@gmail.com>
Date: Thu, 23 Mar 2017 00:28:53 +0100
Subject: [PATCH] org: Liberate org-property-action

* lisp/org.el (org-property-action): Remove unnecessary restriction
  for property action.
---
 lisp/org.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 126318aa3..d122184c7 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15535,7 +15535,6 @@ See `org-property-re' for match data, if applicable."
 (defun org-property-action ()
   "Do an action on properties."
   (interactive)
-  (unless (org-at-property-p) (user-error "Not at a property"))
   (message "Property Action:  [s]et  [d]elete  [D]elete globally  [c]ompute")
   (let ((c (read-char-exclusive)))
     (cl-case c
-- 
2.12.0


             reply	other threads:[~2017-03-22 23:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 23:47 Marco Wahl [this message]
2017-03-23  8:49 ` [PATCH] org: Liberate org-property-action Nicolas Goaziou
2017-03-23 10:06   ` Marco Wahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84d1d8ho20.fsf@tm6592 \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).