From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:f42::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8IP2MNT/ymGiZQAAgWs5BA (envelope-from ) for ; Tue, 28 Dec 2021 13:15:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oHTqLdT/ymFFSQAAauVa8A (envelope-from ) for ; Tue, 28 Dec 2021 13:15:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 035A5323FC for ; Tue, 28 Dec 2021 13:15:16 +0100 (CET) Received: from localhost ([::1]:43388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2BNr-00015m-1X for larch@yhetil.org; Tue, 28 Dec 2021 07:15:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2BL4-00013r-Kt for emacs-orgmode@gnu.org; Tue, 28 Dec 2021 07:12:22 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:60477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2BL1-0006C4-Q1 for emacs-orgmode@gnu.org; Tue, 28 Dec 2021 07:12:21 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 40D8832002E2 for ; Tue, 28 Dec 2021 07:12:16 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 28 Dec 2021 07:12:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eml.cc; h= message-id:subject:from:to:in-reply-to:references:content-type :date:mime-version; s=fm2; bh=gcavDOfZLoPxiSK4iP0wWBkBrbnDBEj20s Nrf+EWBXU=; b=mMryJacqD9YCdyxnhUMCqJ9jZXTyW3/hrWVMPcobvDQMFok8Wq evoGXXOE3OVxjbYia3gEH7nzimIOx8LlTiFM+dsfWlXA9IMGlP9t04P/I97n5eZx jguPVLmCfSFOQtojfV7f7kenRLBzEPoh4/IjD2pqyYKI8+qhnHaJt4ejFAbaeELI mnmlFk5DS3S0QWZgwqjRmeYq17HNgfinDh203/+7F9+rY5c43GDZFei9nrpcJOYK +NfedoeHuQsGv98tLgWaEMWE09W56Upg+lL6N7kf1cFAiRsUQZ1CK172FgUVKGrQ F2zkWq3aCyOn6K3X6aquAaCbCrP+V0HKhxnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=gcavDO fZLoPxiSK4iP0wWBkBrbnDBEj20sNrf+EWBXU=; b=k+71Kmwd1Y7SCQ9hoUIUkV LXz8zpafPIWfgyxJaa3JJp3RPeMtGUoxazWPLMD5FpKGMzv6Pi5/61JMNkK1M214 dJinJRnVpkEKMCJ0WdIFyezP0Ltz9itrxnpKRKryuH3I+a8/jI+y5rIcRikNMetu VB6UgIPy7zBaT20nSjjntAcgJ6e5TQoYcEDRDc7aQQjvguvu5pu4d02YPZxbcIpc RItuEHh0F7ttd3dUZIMT5hoPXykkT/N4kVwIghkxF7/jepcE9uo+jQbLL2Ahjv0h iLNU/Chotgn1EEam8QBNDqfWYCuLsjGp0yI04yhgnF13o0FcXKOE2qVdHhO4fULA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudduledgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfedtmdenucfjughrpefkuffhvfgjfhgtffggfgesmhdtreertder jeenucfhrhhomhepofhikhhhrghilhcuufhkohhriihhihhnshhkihhiuceomhhskhhorh iihhhinhhskhhihiesvghmlhdrtggtqeenucggtffrrghtthgvrhhnpeehteevledufeel ffeljedvgfekgffghfffteduffeghfeukeehtdeluddtudehleenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmshhkohhriihhihhnshhkihih segvmhhlrdgttg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 28 Dec 2021 07:12:14 -0500 (EST) Message-ID: <8451fcc20c68d9863a4613df5a1cd5dbba0a77cd.camel@eml.cc> Subject: Re: [PATCH] ox-icalendar.el: customizable vevent summary prefix From: Mikhail Skorzhinskii To: Org Mode In-Reply-To: <871r1zawhp.fsf@nicolasgoaziou.fr> References: <0a1b98af1974ec260c4074df056715e237c08fce.camel@eml.cc> <871r1zawhp.fsf@nicolasgoaziou.fr> Content-Type: multipart/mixed; boundary="=-1T1kwNl5VwJScxvEy2Y7" Date: Tue, 28 Dec 2021 13:10:22 +0100 MIME-Version: 1.0 User-Agent: Evolution 3.40.4-1 Received-SPF: pass client-ip=64.147.123.21; envelope-from=mskorzhinskiy@eml.cc; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640693716; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gcavDOfZLoPxiSK4iP0wWBkBrbnDBEj20sNrf+EWBXU=; b=Z07kxd3a1x+PEkGkiEZoPciJPzTfbDoQ+O7gR69qoEN6wBKjdPGteIMv1fXZn5RrDfMSs9 sceWdRCiLIoxjb7jRwC7z6Tz0y9KFqxeGKecxxWynhkV5ZMqeClgUIbg5AxR5b7HkAsorP 3TfIDgx3Bp6BS1Rh0+YtRAMntvyAD/JtvIHBpkTk0zuT8ywud/Azk9fTZpB+Gka3SumOdC Pg/f8aFPBy51Mh+k98akA1WWy811beIMNgu5VO+RcNMSd+AhUL+NB12H5mzuZP54csUDFM F/Lw8BKMqDTySWGyRPaf4vx6mGx1OXDApNqUv4wSal05Ryt9sgExyNUUGCNqLg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640693716; a=rsa-sha256; cv=none; b=WEcRpEmGlQJMdoL0NuoAz3++1R9GaE0tFWAysJjT20XkDcKAMpCuczzTZvhyno0b8bD54d migpZnMOcFvyIY1Nzw0A0MabpoTYtPnQPLyNjTmcHFkGEcvOu110ROzVCIlz+ZrfYaF5jD GpsPoM1d1EqjLTIInGgQBk5+/CKGaxD8TrJUnAyzBrx/RpdbGUKSGDl0DliT23H0NXaNgG MVE0wx9clMpQq7QeZ8zytp08sfti5hle5Q7+84k5BUYU/u+iKKvq4XtrkAUqIQQ7HTpRNn NZnMem08QI5ggUoabwB2ocLQubANxDWM/GxcekCp+pckVGlRGw6NVjhxTl3wbQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=eml.cc header.s=fm2 header.b=mMryJacq; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=k+71Kmwd; dmarc=pass (policy=none) header.from=eml.cc; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.27 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=eml.cc header.s=fm2 header.b=mMryJacq; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=k+71Kmwd; dmarc=pass (policy=none) header.from=eml.cc; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 035A5323FC X-Spam-Score: -4.27 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7ulOSGqyY4Ao --=-1T1kwNl5VwJScxvEy2Y7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi Nicolas, Thank you for the reviewing my suggestions. I've fixed issues you've listed. I've attached new patch to this email. Let me know what you think. Thanks, Mikhail On Sun, 2021-12-26 at 22:26 +0100, Nicolas Goaziou wrote: > Hello, > > Thanks. Some comments follow. > > Mikhail Skorzhinskii writes: > > > * lisp/ox-icalendar.el (org-icalendar-scheduled-summary-prepend): > > configurable prefix for the scheduled headlines > > "New variable" is enough. > > > * lisp/ox-icalendar.el (org-icalendar-deadline-summary-prepend): > > configurable prefix for the headlines with a deadline > > Ditto. > > > +(defcustom org-icalendar-scheduled-summary-prepend "S: " > > +  "String used for prepending summary in exported scheduled > > headlines." > > +  :group 'org-export-icalendar > > +  :type 'string) > > + > > + > > +(defcustom org-icalendar-deadline-summary-prepend "DL: " > > +  "String used for prepending summary in exported deadlines." > > +  :group 'org-export-icalendar > > +  :type 'string) > > + > > Could you add missing :safe and :package-version keywords? > > Regards, --=-1T1kwNl5VwJScxvEy2Y7 Content-Disposition: attachment; filename="0003-ox-icalendar.el-customizable-vevent-summary-prefix.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0003-ox-icalendar.el-customizable-vevent-summary-prefix.patch"; charset="UTF-8" RnJvbSA2ODQ5ZjBkZGUxY2M4ZmVmYmZlYTAyNzEwMzllNTA2NmEzY2IyNzQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtoYWlsIFNrb3J6aGluc2tpaSA8bXNrb3J6aGluc2tpeUBl bWwuY2M+CkRhdGU6IFNhdCwgMTIgU2VwIDIwMjAgMTg6Mjc6MjMgKzAyMDAKU3ViamVjdDogW1BB VENIIDMvNV0gb3gtaWNhbGVuZGFyLmVsOiBjdXN0b21pemFibGUgdmV2ZW50IHN1bW1hcnkgcHJl Zml4CgoqIGxpc3Avb3gtaWNhbGVuZGFyLmVsIChvcmctaWNhbGVuZGFyLXNjaGVkdWxlZC1zdW1t YXJ5LXByZXBlbmQpOiBuZXcKdmFyaWFibGUKKiBsaXNwL294LWljYWxlbmRhci5lbCAob3JnLWlj YWxlbmRhci1kZWFkbGluZS1zdW1tYXJ5LXByZXBlbmQpOiBuZXcKdmFyaWFibGUKKiBsaXNwL294 LWljYWxlbmRhci5lbCAob3JnLWljYWxlbmRhci1lbnRyeSk6IHVzZSBhIGNvbmZpZ3VyYWJsZQpo ZWFkbGluZSBwcmVmaXhlcyAoc2VlIGFib3ZlKSBpbnN0ZWFkIG9mIGhhcmRjb2RlZCBvbmVzCi0t LQogbGlzcC9veC1pY2FsZW5kYXIuZWwgfCAxOSArKysrKysrKysrKysrKysrKy0tCiAxIGZpbGUg Y2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9s aXNwL294LWljYWxlbmRhci5lbCBiL2xpc3Avb3gtaWNhbGVuZGFyLmVsCmluZGV4IDY4YzU2Nzll YS4uMTg5ZTM1OTQ2IDEwMDY0NAotLS0gYS9saXNwL294LWljYWxlbmRhci5lbAorKysgYi9saXNw L294LWljYWxlbmRhci5lbApAQCAtODQsNiArODQsMjEgQEAga2V5d29yZC4iCiAgIDpncm91cCAn b3JnLWV4cG9ydC1pY2FsZW5kYXIKICAgOnR5cGUgJyhyZXBlYXQgKHN0cmluZyA6dGFnICJUYWci KSkpCiAKKyhkZWZjdXN0b20gb3JnLWljYWxlbmRhci1zY2hlZHVsZWQtc3VtbWFyeS1wcmVwZW5k ICJTOiAiCisgICJTdHJpbmcgdXNlZCBmb3IgcHJlcGVuZGluZyBzdW1tYXJ5IGluIGV4cG9ydGVk IHNjaGVkdWxlZCBoZWFkbGluZXMuIgorICA6Z3JvdXAgJ29yZy1leHBvcnQtaWNhbGVuZGFyCisg IDp0eXBlICdzdHJpbmcKKyAgOnBhY2thZ2UtdmVyc2lvbiAnKE9yZyAuICI5LjYiKQorICA6c2Fm ZSAjJ3N0cmluZ3ApCisKKworKGRlZmN1c3RvbSBvcmctaWNhbGVuZGFyLWRlYWRsaW5lLXN1bW1h cnktcHJlcGVuZCAiREw6ICIKKyAgIlN0cmluZyB1c2VkIGZvciBwcmVwZW5kaW5nIHN1bW1hcnkg aW4gZXhwb3J0ZWQgZGVhZGxpbmVzLiIKKyAgOmdyb3VwICdvcmctZXhwb3J0LWljYWxlbmRhcgor ICA6dHlwZSAnc3RyaW5nCisgIDpwYWNrYWdlLXZlcnNpb24gJyhPcmcgLiAiOS42IikKKyAgOnNh ZmUgIydzdHJpbmdwKQorCiAoZGVmY3VzdG9tIG9yZy1pY2FsZW5kYXItdXNlLWRlYWRsaW5lICco ZXZlbnQtaWYtbm90LXRvZG8gdG9kby1kdWUpCiAgICJDb250ZXh0cyB3aGVyZSBpQ2FsZW5kYXIg ZXhwb3J0IHNob3VsZCB1c2UgYSBkZWFkbGluZSB0aW1lIHN0YW1wLgogCkBAIC02MDcsNyArNjIy LDcgQEAgaW5saW5ldGFzayB3aXRoaW4gdGhlIHNlY3Rpb24uIgogCQkgICAoXyAobWVtcSAnZXZl bnQtaWYtbm90LXRvZG8gdXNlLWRlYWRsaW5lKSkpCiAJCSAob3JnLWljYWxlbmRhci0tdmV2ZW50 CiAJCSAgZW50cnkgZGVhZGxpbmUgKGNvbmNhdCAiREwtIiB1aWQpCi0JCSAgKGNvbmNhdCAiREw6 ICIgc3VtbWFyeSkgbG9jIGRlc2MgY2F0IHR6IGNsYXNzKSkpCisJCSAgKGNvbmNhdCBvcmctaWNh bGVuZGFyLWRlYWRsaW5lLXN1bW1hcnktcHJlcGVuZCBzdW1tYXJ5KSBsb2MgZGVzYyBjYXQgdHog Y2xhc3MpKSkKIAkgIChsZXQgKChzY2hlZHVsZWQgKG9yZy1lbGVtZW50LXByb3BlcnR5IDpzY2hl ZHVsZWQgZW50cnkpKQogCQkodXNlLXNjaGVkdWxlZCAocGxpc3QtZ2V0IGluZm8gOmljYWxlbmRh ci11c2Utc2NoZWR1bGVkKSkpCiAJICAgIChhbmQgc2NoZWR1bGVkCkBAIC02MTgsNyArNjMzLDcg QEAgaW5saW5ldGFzayB3aXRoaW4gdGhlIHNlY3Rpb24uIgogCQkgICAoXyAobWVtcSAnZXZlbnQt aWYtbm90LXRvZG8gdXNlLXNjaGVkdWxlZCkpKQogCQkgKG9yZy1pY2FsZW5kYXItLXZldmVudAog CQkgIGVudHJ5IHNjaGVkdWxlZCAoY29uY2F0ICJTQy0iIHVpZCkKLQkJICAoY29uY2F0ICJTOiAi IHN1bW1hcnkpIGxvYyBkZXNjIGNhdCB0eiBjbGFzcykpKQorCQkgIChjb25jYXQgb3JnLWljYWxl bmRhci1zY2hlZHVsZWQtc3VtbWFyeS1wcmVwZW5kIHN1bW1hcnkpIGxvYyBkZXNjIGNhdCB0eiBj bGFzcykpKQogCSAgOzsgV2hlbiBjb2xsZWN0aW5nIHBsYWluIHRpbWVzdGFtcHMgZnJvbSBhIGhl YWRsaW5lIGFuZCBpdHMKIAkgIDs7IHRpdGxlLCBza2lwIGlubGluZXRhc2tzIHNpbmNlIGNvbGxl Y3Rpb24gd2lsbCBoYXBwZW4gb25jZQogCSAgOzsgRU5UUlkgaXMgb25lIG9mIHRoZW0uCi0tIAoy LjMyLjAKCg== --=-1T1kwNl5VwJScxvEy2Y7--