From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marco Wahl <marcowahlsoft@gmail.com>
Subject: Re: Old 'C-c tab' binding shadowed
Date: Fri, 08 Sep 2017 00:11:11 +0200
Message-ID: <84377yupkw.fsf@tm6592>
References: <84lglqgvcv.fsf@tm6592>
	<CAFyQvY2OxMs=d5iNzgrXbLud+wuMrM2qMU--cqBb6Sjx0zmamw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcowahlsoft@gmail.com>) id 1dq516-0004iK-KK
	for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 18:11:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcowahlsoft@gmail.com>) id 1dq511-0002HK-Lf
	for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 18:11:20 -0400
Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:43017)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <marcowahlsoft@gmail.com>)
	id 1dq511-0002GU-EY
	for emacs-orgmode@gnu.org; Thu, 07 Sep 2017 18:11:15 -0400
Received: by mail-wm0-x231.google.com with SMTP id f145so1941510wme.0
	for <emacs-orgmode@gnu.org>; Thu, 07 Sep 2017 15:11:15 -0700 (PDT)
In-Reply-To: <CAFyQvY2OxMs=d5iNzgrXbLud+wuMrM2qMU--cqBb6Sjx0zmamw@mail.gmail.com>
	(Kaushal Modi's message of "Thu, 07 Sep 2017 19:53:16 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-orgmode@gnu.org

>> I think the bindings could coexist peacefully since
>>
> `org-table-toggle-column-width' makes sense only for the cursor located
>> in a table and `outline-show-children' makes most sense (AFAICS) when
>> called on a headline.
>>
>> Does this sound reasonable?
>>
>> Does anyone see clearly how to implement this?  (I don't.)
>>
>
> I  always wondered the same about other org-table-* bindings in org.el.
>
> This works:
>
> diff --git a/lisp/org.el b/lisp/org.el
> index a03d8c5a429..cba9b20482f 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -19632,7 +19632,12 @@ COMMANDS is a list of alternating OLDDEF NEWDEF
> command names."
>  (org-defkey org-mode-map "\C-j"     'org-return-indent)
>  (org-defkey org-mode-map "\C-c?"    'org-table-field-info)
>  (org-defkey org-mode-map "\C-c "    'org-table-blank-field)
> -(org-defkey org-mode-map (kbd "C-c TAB") #'org-table-toggle-column-width)
> +(org-defkey org-mode-map (kbd "C-c TAB")
> +            '(menu-item "toggle-column-width-when-in-table" nil
> +                        :filter (lambda (&optional _)
> +                                  (if (org-at-table-p)
> +                                      #'org-table-toggle-column-width
> +    #'outline-show-children))))
>  (org-defkey org-mode-map "\C-c+"    'org-table-sum)
>  (org-defkey org-mode-map "\C-c="    'org-table-eval-formula)
>  (org-defkey org-mode-map "\C-c'"    'org-edit-special)
>
> I actually do this for org-table-* bindings in my config:
>
>     ;; Bind the "org-table-*" command ONLY when the point is in an Org
> table.
>     ;; http://emacs.stackexchange.com/a/22457/115
>     (bind-keys
>      :map org-mode-map
>      :filter (org-at-table-p)
>      ("C-c ?" . org-table-field-info)
>      ("C-c SPC" . org-table-blank-field)
>      ("C-c +" . org-table-sum)
>      ("C-c =" . org-table-eval-formula)
>      ("C-c `" . org-table-edit-field)
>      ("C-#" . org-table-rotate-recalc-marks)
>      ("C-c }" . org-table-toggle-coordinate-overlays)
>      ("C-c {" . org-table-toggle-formula-debugger))
>
> Inspiration:
> http://endlessparentheses.com/define-context-aware-keys-in-emacs.html

Thanks!

Good to know a path to a personal configuration for the case no one else
is interested in the old C-c TAB behavior.


Ciao,
     Marco