bug#18035: Linum-mode + org-indent-mode results in graphical bug

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Eli Zaretskii]

> From: Lionel Henry <lionel.hry@gmail.com>
> Date: Wed, 16 Jul 2014 15:39:04 +0200
> 
> Activating both linum-mode and org-indent-mode will cause several graphical glitches in the current line.
> See http://lists.gnu.org/archive/html/emacs-orgmode/2011-01/msg01204.html

That discussion provides no reproducible recipe.

If I start "emacs -Q", visit an Org file, then invoke org-indent-mode
in that Org buffer, and finally turn on linum-mode, I see nothing like
this:

  clicking on any line in an org-mode file will cause the cursor and
  text on the line to quickly shift back a few spaces, and the line
  number for that line to disappear, and then after a fraction of a
  second it will return to normal.

When I click on a line, nothing happens, except that the cursor jumps
to the place where I clicked.

I tried with both the latest trunk and emacs-24 branch, using the
version of Org provided with each branch.

So please provide a reproducible recipe, starting from "emacs -Q", and
perhaps also an Org file where you see the problem.  If there is a
need to use a version of Org newer than the ones currently in the
Emacs repository, please tell where to get that version of Org.

Thank you.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Lionel Henry]

I cannot reproduce it with emacs -Q
I will try to investigate which of my settings causes the problem.

Thanks for your time.


Le 16 juil. 2014 à 18:38, Eli Zaretskii <eliz@gnu.org> a écrit :

>> From: Lionel Henry <lionel.hry@gmail.com>
>> Date: Wed, 16 Jul 2014 15:39:04 +0200
>> 
>> Activating both linum-mode and org-indent-mode will cause several graphical glitches in the current line.
>> See http://lists.gnu.org/archive/html/emacs-orgmode/2011-01/msg01204.html
> 
> That discussion provides no reproducible recipe.
> 
> If I start "emacs -Q", visit an Org file, then invoke org-indent-mode
> in that Org buffer, and finally turn on linum-mode, I see nothing like
> this:
> 
>  clicking on any line in an org-mode file will cause the cursor and
>  text on the line to quickly shift back a few spaces, and the line
>  number for that line to disappear, and then after a fraction of a
>  second it will return to normal.
> 
> When I click on a line, nothing happens, except that the cursor jumps
> to the place where I clicked.
> 
> I tried with both the latest trunk and emacs-24 branch, using the
> version of Org provided with each branch.
> 
> So please provide a reproducible recipe, starting from "emacs -Q", and
> perhaps also an Org file where you see the problem.  If there is a
> need to use a version of Org newer than the ones currently in the
> Emacs repository, please tell where to get that version of Org.
> 
> Thank you.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Michael Heerdegen]

Eli Zaretskii <eliz@gnu.org> writes:

> > Activating both linum-mode and org-indent-mode will cause several
> > graphical glitches in the current line.
> > See
> > http://lists.gnu.org/archive/html/emacs-orgmode/2011-01/msg01204.html
>
> That discussion provides no reproducible recipe.

FWIW, I think we see something similar or related in helm:

  https://github.com/emacs-helm/helm/issues/560

Sadly, there's also no recipe for emacs -Q.


Michael.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Michael Heerdegen]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> > > Activating both linum-mode and org-indent-mode will cause several
> > > graphical glitches in the current line.
> > > See
> > > http://lists.gnu.org/archive/html/emacs-orgmode/2011-01/msg01204.html
> >
> > That discussion provides no reproducible recipe.

But I think I found something that is related (before-string overlays
vs. text properties) and is reproducible for emacs -Q:

- visit a file under version control (I tried a git controlled file here)
- M-x vc-annotate
- v (i.e. vc-annotate-toggle-annotation-visibility)
- M-x linum-mode

==> all lines but one loose their coloring.  Those lines that are still
colored loose their line number.

nlinum-mode behaves similarly.


Michael.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Eli Zaretskii]

> From: Michael Heerdegen <michael_heerdegen@web.de>
> Cc: 18035@debbugs.gnu.org,  Lionel Henry <lionel.hry@gmail.com>
> Date: Wed, 16 Jul 2014 20:14:46 +0200
> 
> Michael Heerdegen <michael_heerdegen@web.de> writes:
> 
> > > > Activating both linum-mode and org-indent-mode will cause several
> > > > graphical glitches in the current line.
> > > > See
> > > > http://lists.gnu.org/archive/html/emacs-orgmode/2011-01/msg01204.html
> > >
> > > That discussion provides no reproducible recipe.
> 
> But I think I found something that is related (before-string overlays
> vs. text properties) and is reproducible for emacs -Q:

It's specific to invisible property, not just any property, and also
requires that another text property starts exactly where the invisible
property ends.

I'm not sure this is the same problem as reported by the OP, so it
probably should have been reported as a separate bug (merging them
later is easy).

> - visit a file under version control (I tried a git controlled file here)
> - M-x vc-annotate
> - v (i.e. vc-annotate-toggle-annotation-visibility)
> - M-x linum-mode
> 
> ==> all lines but one loose their coloring.  Those lines that are still
> colored loose their line number.
> 
> nlinum-mode behaves similarly.

Fixed in revision 117382 on the emacs-24 branch.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Michael Heerdegen]

Eli Zaretskii <eliz@gnu.org> writes:


> [...]  I'm not sure this is the same problem as reported by the OP, so
> it probably should have been reported as a separate bug (merging them
> later is easy).

Ok.  I wasn't sure what would be best.


> > - visit a file under version control (I tried a git controlled file
> > here)
> > - M-x vc-annotate
> > - v (i.e. vc-annotate-toggle-annotation-visibility)
> > - M-x linum-mode
> > 
> > ==> all lines but one loose their coloring.  Those lines that are still
> > colored loose their line number.
> > 
> > nlinum-mode behaves similarly.
>
> Fixed in revision 117382 on the emacs-24 branch.

Works for me, thanks!


Michael.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Lionel Henry]

Le 16 juil. 2014 à 18:38, Eli Zaretskii <eliz@gnu.org> a écrit :

>> From: Lionel Henry <lionel.hry@gmail.com>
>> Date: Wed, 16 Jul 2014 15:39:04 +0200
>> 
>> Activating both linum-mode and org-indent-mode will cause several graphical glitches in the current line.
>> See http://lists.gnu.org/archive/html/emacs-orgmode/2011-01/msg01204.html
> 
> That discussion provides no reproducible recipe.

OK I finally found a ROA

First create a .org file and put the rainbow-delimiters package in your load path.
Then execute this :

(progn
  (require 'rainbow-delimiters)
  (rainbow-delimiters-mode)
  (linum-mode)
  (org-indent-mode))

Then enter this in the org file :

* head 1
** head 2
line 1
line 2

Line 2 is important, without it the bug does not happens. Now modify head 2.
The linum number will disappear and the whole active line will shift to the left.

So it's an interaction between linum, org-indent-mode, and rainbow-delimiters-mode.


Lionel

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Lionel Henry]

> So it's an interaction between linum, org-indent-mode, and rainbow-delimiters-mode.

Of course rainbow-delimiters is not very useful in org files, so this is not a very
important bug. I'll just disable it for org-mode.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Eli Zaretskii]

> From: Lionel Henry <lionel.hry@gmail.com>
> Date: Sat, 26 Jul 2014 17:03:49 +0200
> Cc: 18035@debbugs.gnu.org,
>  michael_heerdegen@web.de
> 
> 
> First create a .org file and put the rainbow-delimiters package in your load path.
> Then execute this :
> 
> (progn
>   (require 'rainbow-delimiters)
>   (rainbow-delimiters-mode)
>   (linum-mode)
>   (org-indent-mode))
> 
> Then enter this in the org file :
> 
> * head 1
> ** head 2
> line 1
> line 2
> 
> Line 2 is important, without it the bug does not happens. Now modify head 2.
> The linum number will disappear and the whole active line will shift to the left.
> 
> So it's an interaction between linum, org-indent-mode, and rainbow-delimiters-mode.

Thanks.

AFAICS, rainbow-delimiters-mode uses the JIT Font Lock machinery to do
its job, which might conflict with org-indent's usage of an idle timer
and/or fail to trigger linum-mode's update on that line.  When I
modify the "head 2" line, the line number is still visible, but then
about a second later the line gets re-indented and the line number
disappears.

I suggest that you report this to the developers of org-indent and
rainbow-delimiters-mode, and ask them to debug this.  If their
conclusion is that this is a core Emacs problem, please get back here
and report the details.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Lionel Henry]

Le 26 juil. 2014 à 17:36, Eli Zaretskii <eliz@gnu.org> a écrit :

> Thanks.
> 
> AFAICS, rainbow-delimiters-mode uses the JIT Font Lock machinery to do
> its job, which might conflict with org-indent's usage of an idle timer
> and/or fail to trigger linum-mode's update on that line.  When I
> modify the "head 2" line, the line number is still visible, but then
> about a second later the line gets re-indented and the line number
> disappears.
> 
> I suggest that you report this to the developers of org-indent and
> rainbow-delimiters-mode, and ask them to debug this.  If their
> conclusion is that this is a core Emacs problem, please get back here
> and report the details.

Ok I will.

But now that I've disabled rainbows and enabled linum in org-mode again,
I found another bug that might be related. With emacs -Q:

- Open a .org file large enough that you can scroll it.
- Enable linum and org-indent-mode
- Scroll

The linum and the indentation will disappear in the very first line.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Eli Zaretskii]

> From: Lionel Henry <lionel.hry@gmail.com>
> Date: Sat, 26 Jul 2014 17:53:47 +0200
> Cc: 18035@debbugs.gnu.org,
>  michael_heerdegen@web.de
> 
> - Open a .org file large enough that you can scroll it.
> - Enable linum and org-indent-mode
> - Scroll
> 
> The linum and the indentation will disappear in the very first line.

Fixed in revision 117413 on the emacs-24 branch.

bug#18035: Linum-mode + org-indent-mode results in graphical bug

[Bastien]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Lionel Henry <lionel.hry@gmail.com>
>> Date: Sat, 26 Jul 2014 17:53:47 +0200
>> Cc: 18035@debbugs.gnu.org,
>>  michael_heerdegen@web.de
>> 
>> - Open a .org file large enough that you can scroll it.
>> - Enable linum and org-indent-mode
>> - Scroll
>> 
>> The linum and the indentation will disappear in the very first line.
>
> Fixed in revision 117413 on the emacs-24 branch.

Thanks!

-- 
 Bastien