From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eli Zaretskii <eliz@gnu.org>
Subject: =?UTF-8?B?YnVnIzIzOTE3OiBQbGVhc2UgY29uc2lkZXIgbWFraW5nIEJ1ZyAj?=
 =?UTF-8?B?MjM5MTcgYSBibG9ja2VyIGZvciAyNS4xICh3YXMgUmU6IG9yZy1jYXB0dXJl?=
 =?UTF-8?B?OiBDYXB0dXJlIHRlbXBsYXRlIOKAmGfigJk6IE1hdGNoIGRhdGEgY2xvYmJl?=
 =?UTF-8?B?cmVkIGJ5IGJ1ZmZlciBtb2RpZmljYXRpb24gaG9va3Mp?=
Date: Thu, 21 Jul 2016 17:26:15 +0300
Message-ID: <83a8hbysmw.fsf__10826.1148365729$1469111343$gmane$org@gnu.org>
References: <87vb066ejv.fsf@linaro.org>
	<87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org>
	<m28tx1o6h6.fsf@newartisans.com> <87a8hgkwcb.fsf@linaro.org>
	<8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com>
	<83lh0y24y6.fsf@gnu.org> <jwvmvle5udz.fsf-monnier+emacsbugs@gnu.org>
	<83eg6q1hbo.fsf@gnu.org> <jwv1t2q5jsz.fsf-monnier+emacsbugs@gnu.org>
	<83a8hd1vzi.fsf@gnu.org> <jwvzipdeibv.fsf-monnier+emacsbugs@gnu.org>
	<834m7l1u8u.fsf@gnu.org> <jwvd1m9dran.fsf-monnier+emacsbugs@gnu.org>
	<83shv4z7e8.fsf@gnu.org> <jwvfur4ch16.fsf-monnier+emacsbugs@gnu.org>
	<83inw0yw9q.fsf@gnu.org> <jwvtwfkvxsc.fsf-monnier+emacsbugs@gnu.org>
	<87bn1rdd1f.fsf@users.sourceforge.net> <83h9bjzp5i.fsf@gnu.org>
	<877fcfd79w.fsf@users.sourceforge.net>
Reply-To: Eli Zaretskii <eliz@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bQEwQ-0007he-1l
	for emacs-orgmode@gnu.org; Thu, 21 Jul 2016 10:27:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1bQEwO-0002CH-1Y
	for emacs-orgmode@gnu.org; Thu, 21 Jul 2016 10:27:09 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.23917.B23917.14691111981187@debbugs.gnu.org>
In-reply-to: <877fcfd79w.fsf@users.sourceforge.net>
	(npostavs@users.sourceforge.net)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: npostavs@users.sourceforge.net
Cc: nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org, monnier@iro.umontreal.ca, alex.bennee@linaro.org

> From: npostavs@users.sourceforge.net
> Cc: 23917@debbugs.gnu.org,  nljlistbox2@gmail.com,  jwiegley@gmail.com,  rpluim@gmail.com,  monnier@iro.umontreal.ca,  alex.bennee@linaro.org
> Date: Wed, 20 Jul 2016 23:00:59 -0400
> 
> > Please also make sure bug#23869 is still fixed after this.
> 
> Following the recipe in
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23869#11 gives me 'Lisp
> error: (error "Match data clobbered by buffer modification hooks")',
> that indicates it's still fixed, right?

Yes, but I thought we want to remove the error-out code.  Since we now
protect ourselves from clobbered data, we don't need that extra
protection, and I think leaving it in place will cause false positives
(as a few people already reported).  That's because the adjustment of
the search registers in the new function you introduce will itself
trigger the error message, won't it?

Perhaps we should error out only if the number of registers changed,
because that can never be valid, I think.