Re: [BUG] ob-sql sql-connection-alist

[Andreas Gerler <baron@bundesbrandschatzamt.de>]

[-- Attachment #1.1: Type: text/plain, Size: 34 bytes --]

Sorry. That was the wrong patch.


[-- Attachment #1.2: 0001-lisp-ob-sql.el-allow-string-in-sql-connection-alist.patch --]
[-- Type: application/octet-stream, Size: 998 bytes --]

From 12661647049bbadeff470c56d17fafc44cae6163 Mon Sep 17 00:00:00 2001
From: Andreas Gerler <baron@bundesbrandschatzamt.de>
Date: Fri, 20 Jan 2023 18:17:51 +0100
Subject: [PATCH] lisp/ob-sql.el: allow string in sql-connection-alist

Signed-off-by: Andreas Gerler <baron@bundesbrandschatzamt.de>
---
 lisp/ob-sql.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ob-sql.el b/lisp/ob-sql.el
index 39a4573a5..f73e7003f 100644
--- a/lisp/ob-sql.el
+++ b/lisp/ob-sql.el
@@ -234,7 +234,7 @@ database connections."
                                   (:database . sql-database)))
                   (mapped-name (cdr (assq name name-mapping))))
              (cadr (assq mapped-name
-                         (cdr (assoc dbconnection sql-connection-alist))))))))
+                         (cdr (assoc-string dbconnection sql-connection-alist t))))))))
 
 (defun org-babel-execute:sql (body params)
   "Execute a block of Sql code with Babel.
-- 
2.39.0


[-- Attachment #1.3: Type: text/plain, Size: 1284 bytes --]



> On 20. Jan 2023, at 18:24, Andreas Gerler <baron@bundesbrandschatzamt.de> wrote:
> 
> <0001-lisp-ob-eval.el-Display-error-fix.patch>
> 
>> On 16. Jan 2023, at 11:25, Daniel Kraus <daniel@kraus.my> wrote:
>> 
>> Hi!
>> 
>> Andreas Gerler <baron@bundesbrandschatzamt.de> writes:
>> 
>>> Last week I heard about using ob-sql with credentials stored in the variable used by isql.
>>> However I had to modify ob-sql to get it actually working.
>>> Can somebody test the pach before I send in a commit?
>>> 
>>> #+begin_src sql :engine mysql :dbconnection testdb
>>> show tables;
>>> #+end_src
>> 
>> I actually use this feature daily.
>> You have to quote the dbconnection. So this works currently:
>> 
>>> #+begin_src sql :engine mysql :dbconnection 'testdb
>> 
>> but I would agree that not needing the quote makes sense.
>> And since `assoc-string` works with symbol and string (i.e. it's backwards compatible)
>> I would install the patch if you send it.
>> 
>>> I was considering writing another patch to map the sql-product to engine.
>>> That way we could get rid of another parameter in the src block.
>>> Opinions?
>> 
>> I agree. Specifying :engine when it's already in the connection-alist is unnecessary.
>> 
>> Thanks,
>> Daniel
> 


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 874 bytes --]