[PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

["Christopher M. Miles" <numbchild@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 981 bytes --]


Ihor Radchenko <yantar92@posteo.net> writes:

> "Christopher M. Miles" <numbchild@gmail.com> writes:
>
>>>> #+begin_src emacs-lisp
>>>> (let ((bound-tags (seq-filter 'cdr temp-fulltable)))
>>>>   (if (length> bound-tags 0)
>>>>       bound-tags
>>>>     (seq-take temp-fulltable 26)))
>>>> #+end_src
>>>
>>> This will unconditionally drop auto-labeled tags when user-bound tags
>>> exist, even if the total number of tags in buffer does not exceed 26.
>>
>> I try to read the source code of `org-fast-tag-selection', but the code is hard to read.
>
> Yeah. I agree. But we have what we have.
>
>> I don't know how to keep auto-labeled tags. Do you have any suggestions?
>
> You are almost there.
> Just run your code only when (lentgh> fulltable 26).
>
> Of course, 26 should be a defcustom rather than a hard-coded constant.
> And do the same for `org-fast-todo-selection'.

Ok, I added defcustom option, and add cl-case condition on custom option
`org-use-fast-tag-selection'.


[-- Attachment #1.2: 0001-org-Improve-the-tags-fast-selection-performance.patch --]
[-- Type: #("text/x-patch" 0 12 (prescient-regexps nil prescient-ignore-case t)), Size: 2083 bytes --]

From 569368aa9b3c7aa5bf1063d3e9c152db5304f4f3 Mon Sep 17 00:00:00 2001
From: stardiviner <numbchild@gmail.com>
Date: Sat, 13 May 2023 22:22:25 +0800
Subject: [PATCH] org: Improve the tags fast selection performance

* lisp/org.el (org-fast-tag-selection): Filter out only maximum number
limited tags has fast selection bound when `org-use-fast-tag-selection'
is 'auto and tags has fast select bound keys.
* lisp/org.el (org-fast-tag-selection-maximum-tags): Add new custom
option to set maximum tags number for fast tag selection.
---
 lisp/org.el | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 542959f73..5d6687b7a 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -2775,6 +2775,12 @@ displaying the tags menu is not even shown, until you press `C-c' again."
 	  (const :tag "Yes" t)
 	  (const :tag "Expert" expert)))
 
+(defcustom org-fast-tag-selection-maximum-tags 26
+  "Set the maximum tags number for fast tag selection."
+  :group 'org-tags
+  :type 'number
+  :safe #'numberp)
+
 (defvar org-fast-tag-selection-include-todo nil
   "Non-nil means fast tags selection interface will also offer TODO states.
 This is an undocumented feature, you should not rely on it.")
@@ -11935,7 +11941,13 @@ Returns the new tags string, or nil to not change the current settings."
 	(org-fast-tag-insert "Current" current c-face "\n\n")
 	(org-fast-tag-show-exit exit-after-next)
 	(org-set-current-tags-overlay current ov-prefix)
-	(setq tbl fulltable char ?a cnt 0)
+	(setq tbl (let ((bound-tags (seq-filter 'cdr fulltable)))
+                    (cl-case org-use-fast-tag-selection
+                      (auto (if (length> bound-tags org-fast-tag-selection-maximum-tags)
+                                bound-tags
+                              (seq-take fulltable org-fast-tag-selection-maximum-tags)))
+                      (t fulltable)))
+              char ?a cnt 0)
 	(while (setq e (pop tbl))
 	  (cond
 	   ((eq (car e) :startgroup)
-- 
2.39.2 (Apple Git-143)


[-- Attachment #1.3: Type: text/plain, Size: 267 bytes --]


-- 

[ stardiviner ]
I try to make every word tell the meaning that I want to express without misunderstanding.

Blog: https://stardiviner.github.io/
IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]