From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2Jj8MnkBjV8zQAAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 03:01:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EFDuLnkBjV/aTwAAbx9fmQ (envelope-from ) for ; Mon, 19 Oct 2020 03:01:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 60AF49402A6 for ; Mon, 19 Oct 2020 03:01:13 +0000 (UTC) Received: from localhost ([::1]:43234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kULQ7-0001IH-9I for larch@yhetil.org; Sun, 18 Oct 2020 23:01:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kULPX-0001HY-Vs for emacs-orgmode@gnu.org; Sun, 18 Oct 2020 23:00:35 -0400 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]:39978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kULPW-0006Ui-6S; Sun, 18 Oct 2020 23:00:35 -0400 Received: by mail-pj1-x1043.google.com with SMTP id j8so4792467pjy.5; Sun, 18 Oct 2020 20:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:references:user-agent:from:to:cc:subject:reply-to :in-reply-to:date:mime-version; bh=eK83GA9cq/vducvTiY+Y6iiFb6DDgS5UxMbrBg7ZPG8=; b=YR/lF3Y1Sqz8mHFhI9phGW0/qxOorUi3dYUlCDeBcPbciTv+QAJL1R69wRM+1YIxLa wbUBWtbwACPwKicx56zm/Hh5NTQFCivRQGmMytft8dtsIaEK+S+NBT7P8zDVP+Cjmm86 RWEs7TG0ci/s1fV1/f8XExNcjAFUe54bNqr2/FJWhf8hl/jl9Fo+XAotsDgFyC1QsYpS SM+5Gf2Hy4K9aniIWaUsJ2IfPE7KI++mb+l8mmfntcmctBG+4I/l0xK762brxdhmd1fC IYHutoVQyzNIusR3LcnhTSDNSxtE5Th4b46D/Tfdij6tGDJbv/av3X/cGMvwW2F4Bqz0 Ylrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:references:user-agent:from:to:cc :subject:reply-to:in-reply-to:date:mime-version; bh=eK83GA9cq/vducvTiY+Y6iiFb6DDgS5UxMbrBg7ZPG8=; b=IAcEs2tANT0BwSQ0RtYTqNep88RU6RRw6f21k51hiVGHqvGKU7vyWRGnpSAnLrnBjJ am9M4gZAC7CZuCBNZwOnIz2Ex33281h4eQHKYxsq9QpBKCy4K1FhqSnSaKjw23kmWGrK ftMAGqMT/OROYBj/PQaVp1fLGlrE/rWcBTJPL1iL4hCE1ER8hHt0+XMFJstsunbWQnDp l5JECKd3Edto5ZiCN5kdNfpcbxDop9dYvwQ0xjImhKgYqaHNR7EUjGiZSxVYothyJEMy ftGYNAvQ+DheWCdKAyLWeabR7hM+J/oz0zgijUQD2v0tZw3zbhE3TGNaK8KmvWDZ2Kr/ y5pA== X-Gm-Message-State: AOAM532eMKlArTlfUyvEkBADsQdvECIw7m9UW+aBQQxTPtJ7E3t9tr1w jddPrGtsTpNaZNJLbvBk5Q== X-Google-Smtp-Source: ABdhPJysPMdtcUKt9D/G1UmXOxZ0w0SqQ/lP8W/r2ed6JWmnk77RGP8CZ6EZY0LR7+7NDfiSh7XG+A== X-Received: by 2002:a17:902:7e82:b029:d3:f3b5:d99a with SMTP id z2-20020a1709027e82b02900d3f3b5d99amr14595824pla.7.1603076431997; Sun, 18 Oct 2020 20:00:31 -0700 (PDT) Received: from dark.localdomain ([183.246.146.5]) by smtp.gmail.com with ESMTPSA id n5sm10023149pfq.46.2020.10.18.20.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2020 20:00:31 -0700 (PDT) Message-ID: <5f8d014f.1c69fb81.b2fdc.5ace@mx.google.com> X-Google-Original-Message-ID: <87blh057al.fsf@numbchild@gmail.com> Received: by dark.localdomain (Postfix, from userid 1000) id D0DCA3C024E; Sun, 18 Oct 2020 15:20:50 +0800 (CST) References: <50f165b2-bdaf-4861-aab5-122cfef7d67c@www.fastmail.com> <5f6aa2e2.1c69fb81.9bff7.9127@mx.google.com> <87k0wkheik.fsf@gnu.org> <5f6b56a1.1c69fb81.ea6da.e0f1@mx.google.com> User-agent: mu4e 1.5.5; emacs 28.0.50 From: stardiviner To: Bastien Subject: Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)] In-reply-to: <5f6b56a1.1c69fb81.ea6da.e0f1@mx.google.com> Date: Sun, 18 Oct 2020 15:20:50 +0800 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1043; envelope-from=numbchild@gmail.com; helo=mail-pj1-x1043.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Cc: Nicholas Savage , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=YR/lF3Y1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: JLH6+Jr2iyGz A simple temporary solution to this bug is remove hook function from ~org-cycle-hook~: #+begin_src emacs-lisp (remove-hook 'org-cycle-hook #'org-cycle-show-empty-lines) #+end_src stardiviner writes: > Bastien writes: > >> Hi, >> >> stardiviner writes: >> >>> I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook >>> ~org-cycle-hook~ caused this problem. >> >> Did you find the commit that introduces this bug? > > I did a git bisect test, found the bad commit. > > "ee3c3b554 | * bad org.el: Allow empty subtrees to be folded back" > >> >> Also, if you can provide a patch, please go ahead. >> > > Can't help on this. Don't know much on regexp matching and position boundries etc. > > Will keep improving skill. -- [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3