From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IPSmOr1Wa18vRwAA0tVLHw (envelope-from ) for ; Wed, 23 Sep 2020 14:07:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iNeSNr1Wa1+2CQAAbx9fmQ (envelope-from ) for ; Wed, 23 Sep 2020 14:07:57 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7423694050D for ; Wed, 23 Sep 2020 14:07:57 +0000 (UTC) Received: from localhost ([::1]:35000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL5R6-0000aS-Ai for larch@yhetil.org; Wed, 23 Sep 2020 10:07:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL5Qj-0000aG-RN for emacs-orgmode@gnu.org; Wed, 23 Sep 2020 10:07:33 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:35673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kL5Qi-0001da-1z; Wed, 23 Sep 2020 10:07:33 -0400 Received: by mail-pf1-x442.google.com with SMTP id k8so15119159pfk.2; Wed, 23 Sep 2020 07:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:references:user-agent:from:to:cc:subject:reply-to :in-reply-to:date:mime-version; bh=8wWTKwwG+Sa/zCikl0TKv2ENTQiXmOQDzslnnLN0kZA=; b=ftXaikVbzQzxYyJBdEqNP9XbB9BYBZoNvvv7UnhLCe0G4ZW4HdjvLEY0CLzzxW5+U4 PditcSotWNtutLAOLexBWbDfanBmh5O1fSVTzvVad5rDu0zi7E2IwGxnGRqYTHpo2Cuc ZVQ2usfSm6p94ZNliPl4FLRLiWtv+n7GgXNPwxjuUogzCW+PTZFUSRHZ1bd5mfVy2ZLh i0Oc6eeK71cd6aM2sYMPbBf37EFmLN35641dK28KUy+EbqbRTIOPXLcweyUEGHP3lh7R uJyXIKm9asR1zzK6AzKkhXC1yPmT5hC7IMsVdJvOLWZRMZgRYJQoZt7A9Xmyp+uZIkrj OhkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:references:user-agent:from:to:cc :subject:reply-to:in-reply-to:date:mime-version; bh=8wWTKwwG+Sa/zCikl0TKv2ENTQiXmOQDzslnnLN0kZA=; b=E1PJeDHkGV1kb/E57T1bRMgFx1lh6tK4V/oY8Z2yteqxAq5kwkPEPS8RnkEy6euHro edSK/3cT6a5Htv4qioGAjRuPT/kWmafwR7Vw//lDr5nBQskSxo60I22tWFy4hW0tgt2p GCsoNlhIQbLXgx1L1xRMFKHIYqfo0G5phyeV6LGf0xf0/wuC+AwpAdV6bK08bKgfh3WB 6fZJ0idFvSkzKAclKYGLnU90z7e/l6F3o/4+iZjohseM/Zzp13sZgf90GEfmMHEhtTaZ v3jmASv+hfu93hJewrZ99l2zj55lNi1EKUciiAnWErNnzN+4fcC/JKxbfR2JckU+zex/ /Dsg== X-Gm-Message-State: AOAM530tX7nKsYYBOYN8W534T+WqZ3euXrJaNJaQpFmTwBsuwbkRsQgs q6yI+AAwx4zoaHDxpprXV8WiHbrWYBPg X-Google-Smtp-Source: ABdhPJyPiWs4fVPSKLMjcqdCYasgHBEMW5TSSY46uwqfToU9MdlRuAyjbXBXH/Fpx0eR3/IoziZcTg== X-Received: by 2002:a05:6a00:887:b029:142:2501:396f with SMTP id q7-20020a056a000887b02901422501396fmr143523pfj.52.1600870050053; Wed, 23 Sep 2020 07:07:30 -0700 (PDT) Received: from dark.gmail.com ([150.109.103.155]) by smtp.gmail.com with ESMTPSA id u14sm19285742pfc.203.2020.09.23.07.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 07:07:29 -0700 (PDT) Message-ID: <5f6b56a1.1c69fb81.ea6da.e0f1@mx.google.com> X-Google-Original-Message-ID: <87o8lwvbbr.fsf@numbchild@gmail.com> References: <50f165b2-bdaf-4861-aab5-122cfef7d67c@www.fastmail.com> <5f6aa2e2.1c69fb81.9bff7.9127@mx.google.com> <87k0wkheik.fsf@gnu.org> User-agent: mu4e 1.5.5; emacs 28.0.50 From: stardiviner To: Bastien Subject: Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)] In-reply-to: <87k0wkheik.fsf@gnu.org> X-Woof-Bug: confirmed Date: Wed, 23 Sep 2020 22:07:25 +0800 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=numbchild@gmail.com; helo=mail-pf1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Cc: Nicholas Savage , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=ftXaikVb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: N+uSHZK8cqiu Bastien writes: > Hi, > > stardiviner writes: > >> I also did a bisect debug. Found the function ~org-cycle-show-empty-lines~ in hook >> ~org-cycle-hook~ caused this problem. > > Did you find the commit that introduces this bug? I did a git bisect test, found the bad commit. "ee3c3b554 | * bad org.el: Allow empty subtrees to be folded back" > > Also, if you can provide a patch, please go ahead. > Can't help on this. Don't know much on regexp matching and position boundries etc. Will keep improving skill. -- [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3