From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erik Hetzner Subject: Re: [PATCH] org-attach.el: Fetch attachments from git annex Date: Tue, 26 Jan 2016 08:39:20 -0800 Message-ID: <56a7a139.885d620a.6b777.576d@mx.google.com> References: <568b532e.d111620a.b25a8.ffffbb7c@mx.google.com> <87poxg8s22.fsf@kyleam.com> <568c6aaa.c345620a.7f4da.6359@mx.google.com> <56a5b193.ca77420a.1551e.667c@mx.google.com> <87lh7dz79f.fsf@gmx.us> <56a70513.6861420a.33633.5843@mx.google.com> <87egd4u6tq.fsf@kyleam.com> Reply-To: Erik Hetzner Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6eR-00054i-VD for emacs-orgmode@gnu.org; Tue, 26 Jan 2016 11:39:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO6eK-0003hv-0r for emacs-orgmode@gnu.org; Tue, 26 Jan 2016 11:39:31 -0500 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:32787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO6eJ-0003he-Pp for emacs-orgmode@gnu.org; Tue, 26 Jan 2016 11:39:23 -0500 Received: by mail-pa0-x229.google.com with SMTP id cy9so100114374pac.0 for ; Tue, 26 Jan 2016 08:39:23 -0800 (PST) In-Reply-To: <87egd4u6tq.fsf@kyleam.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Kyle Meyer Cc: emacs-orgmode@gnu.org On Mon, 25 Jan 2016 23:40:33 -0800, Kyle Meyer wrote: >=20 > Erik Hetzner writes: >=20 > [=E2=80=A6] > > * mk/targets.mk: Fix cleantest target to for deleting git annex repos. > ^^^^^^ > Typo Thank you! > [=E2=80=A6] >=20 > s/if/when/ I=E2=80=99m sorry, you said this before, but I=E2=80=99ve always used =3Dif= =3D except in the case where I=E2=80=99d otherwise need =3Dprogn=3D. Is the principle here that = =3Dwhen=3D should be used when there is no else block? Is there a style guide that I should be referring to before submitting patches? > [...] >=20 > > - (mapcar #'list files) nil t)))) > > - (org-open-file (expand-file-name file attach-dir) in-emacs))) > > + (mapcar #'list files) nil t))) > > + (path (expand-file-name file attach-dir))) > > + (org-attach-annex-get-maybe path) > > + (org-open-file path in-emacs))) >=20 > I think it's a mistake to always run git annex get and to remove the > message, because this process can hang if all the repos with the file > are unavailable. >=20 > This is also one of the reasons why I think there should be an option to > turn off automatic fetching. Users should be able to stop org-attach > from trying to make connections. I have to admit I am reluctant to add another option to org-mode. What do y= ou think about a y-or-n-p if the file needs fetching that will ask if the user would like to get the file from git annex? best, Erik -- Sent from my free software system .