From mboxrd@z Thu Jan  1 00:00:00 1970
From: Florian Lindner <mailinglists@xgm.de>
Subject: Re: Moving and resetting attachments
Date: Wed, 28 Jun 2017 16:57:39 +0200
Message-ID: <4bc8ab3b-173f-b093-fd0d-3b2769683cb6@xgm.de>
References: <ogmcua$c4l$1@blaine.gmane.org>
	<874lw05njr.fsf@ericabrahamsen.net> <ogot9c$aqj$1@blaine.gmane.org>
	<8737bi21dc.fsf@ericabrahamsen.net> <oh8bbr$463$1@blaine.gmane.org>
	<87mv9gz43o.fsf@nicolasgoaziou.fr>
	<f1c95d02-d856-69ec-9bf3-beb22d803839@xgm.de>
	<87tw3jr2f8.fsf@nicolasgoaziou.fr>
	<5b786b61-8cf2-6635-5000-fa25512242be@xgm.de>
	<87mv8x4vhu.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54739)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mailinglists@xgm.de>) id 1dQEPX-0001AH-8N
	for emacs-orgmode@gnu.org; Wed, 28 Jun 2017 10:57:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mailinglists@xgm.de>) id 1dQEPW-0005sE-Cy
	for emacs-orgmode@gnu.org; Wed, 28 Jun 2017 10:57:43 -0400
Received: from venus.centershock.net ([2a03:4000:13:2f1::1]:44592)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mailinglists@xgm.de>) id 1dQEPW-0005rJ-64
	for emacs-orgmode@gnu.org; Wed, 28 Jun 2017 10:57:42 -0400
In-Reply-To: <87mv8x4vhu.fsf@nicolasgoaziou.fr>
Content-Language: en-US
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

Am 24.06.2017 um 10:53 schrieb Nicolas Goaziou:> Hello,
>
> Florian Lindner <mailinglists@xgm.de> writes:
>
>> Ok, so it's basically a conversion to bool.
>
> Correct.
>
>> That I'm not so sure of. I try to get myself aquainted to ert, but my elisp knowledge, you surely know, is very limited.
>
> I think you're doing well so far.
>
>> Do I understand correctly, that there is no test for any org-attach stuff so far? I've found
lisp/test-org-attach-annex.el, but that's for git-annex
>> stuff.
>
> That's correct. Anyway, tests can be postponed to a later patch. It can
> be cumbersome to play with temporary files without clobbering the
> repository.
>
> However, I think tests are important in this case, considering we're
> moving user's data around.

Hey,

I have attached a patch, based on the current git master. I'm not sure how the contribution process works. Do I need to
sign stuff such as copyright assignement? Do you use a Git webinterface, GitHub or Lab?

Writing a test for it is on my todo list.

Best,
Florian