From: Martin Pohlack <mp26@os.inf.tu-dresden.de>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Matt Lundin <mdl@imapmail.org>, emacs-orgmode@gnu.org
Subject: Re: Re: skip entry with inherited tags
Date: Wed, 04 Aug 2010 23:38:07 +0200 [thread overview]
Message-ID: <4C59DDBF.8080105@os.inf.tu-dresden.de> (raw)
In-Reply-To: <A5E331FE-CFF5-4CE0-B90B-C253D33E1C07@gmail.com>
Hi Carsten,
On 22.07.2010 09:38, Carsten Dominik wrote:
> Hi Martin,
>
> On Jul 21, 2010, at 4:32 PM, Carsten Dominik wrote:
>
>> Hi Martin,
>>
>> I just looked at your patch.
>>
>> If I have a normal agenda (i.e. *not* a block agenda), then your
>> patch will cause the preset filter *not* to be applied.
>
> OK, that was obviously incorrect, sorry about that.
>
> However, it still does not work correctly, here is the counter example:
>
> -----------------------------------------------------------------------------
> * TODO test 1 :a:
> * TODO test 2 :b:
>
> * at 1 :a:
> SCHEDULED: <2010-07-22 Thu>
> * at 1 :b:
> SCHEDULED: <2010-07-22 Thu>
> ------------------------------------------------------------------------------
Here is what I found to be incorrect.
* For unmodified org-mode, this ignores the org-agenda-filter-preset.
Is this what you mean or is anything else broken?
* For my patched version, too much is hidden and only revealed after
clearing the global filter. Did you mean anything else?
> With this custom command:
>
> (setq org-agenda-custom-commands
> '(("x" "testmartin"
> ((agenda "" ((org-agenda-filter-preset '("+a"))))
> (alltodo "" ((org-agenda-filter-preset '("+b")))))
> nil nil)))
>
> the result is incorrect, both with and without your patch.
But in different ways, as state above.
> The internal logic of the filter and the preset filter is such that
> it applies to the entire view, and you should not set in the local
> options for a command that is part of a block agenda view.
Well, it is already partly there in that local filters are stored in
text properties for each line. Maybe we can extend this a bit to remove
this limitation?
I will look into it if I have more time.
Cheers,
Martin
next prev parent reply other threads:[~2010-08-04 21:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 7:42 skip entry with inherited tags Matthias Teege
2010-05-18 11:18 ` Martin Pohlack
2010-05-18 17:25 ` Matt Lundin
2010-06-03 21:44 ` Martin Pohlack
2010-06-04 11:27 ` Carsten Dominik
2010-06-04 12:11 ` Martin Pohlack
2010-07-07 8:49 ` Martin Pohlack
2010-07-13 11:49 ` Carsten Dominik
2010-07-13 17:41 ` Martin Pohlack
2010-07-13 18:48 ` Carsten Dominik
2010-07-13 20:34 ` Martin Pohlack
2010-07-21 14:32 ` Carsten Dominik
2010-07-22 7:38 ` Carsten Dominik
2010-08-04 21:38 ` Martin Pohlack [this message]
2010-08-16 12:50 ` Carsten Dominik
2010-08-16 12:56 ` Martin Pohlack
2010-08-16 13:10 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C59DDBF.8080105@os.inf.tu-dresden.de \
--to=mp26@os.inf.tu-dresden.de \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mdl@imapmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).