emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Martin Pohlack <mp26@os.inf.tu-dresden.de>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Vinicius Jose Latorre <viniciusjl@ig.com.br>, emacs-orgmode@gnu.org
Subject: Re: Org-mode version 6.32trans and 6.21b; Strange interaction between whitespace-mode and cust. org-ellipsis
Date: Mon, 14 Dec 2009 20:51:37 +0100	[thread overview]
Message-ID: <4B269749.5030507@os.inf.tu-dresden.de> (raw)
In-Reply-To: <05105BC1-7F54-4439-BAAA-5065ACFC44C3@gmail.com>

Hi Carsten,

On 14.12.2009 17:27, Carsten Dominik wrote:
> i can follow your arguments and would like to improve this.
> 
> What I do not understand yet is this:
> 
> I was under the impression that normally, there is only a single
> display table in Emacs, and that is the global one and every buffer
> will use it.

Interesting, I had the opposite impression.  I'm not exactly sure why
though.  Maybe from the documentation and name of the variable
buffer-display-table?

Maybe you had standard-display-table in mind?

  "Variable: Display table to use for buffers that specify none.
   See `buffer-display-table' for more information."

I have, however, never seen a spelled out convention regarding deep
sharing of display tables.

> So it would seem to me that whitespace-mode would normally
> *make* a local table in order to put its changes in there.  However,
> that does not seem to be the case here.  Can you see why?

I think whitespace-mode usually assumes that the local display tables
is, well, local.  Therefore, no action would be required.

I forwarded my original bug-report to Vinicius Jose Latorre
(whitespace-mode's maintainer) after you mentioned it would be a
whitespace-mode bug.

He replied:

> Well, the problem was due to the way whitespace deal with 
> buffer-display-table variable.
> 
> I've just fixed this problem in Emacs CVS and EmacsWiki.

Here is the patch:

http://lists.gnu.org/archive/html/emacs-diffs/2009-12/msg00184.html

He basically creates a deep copy (the copy-sequence line) of the local
display table and installs it.  This should solve the problem.


I still have this nagging feeling that the sharing of the display table
is not the right thing to do and would regard the fix in whitespace-mode
as a kind of emergence case backup.  But this is probably purely a style
thing.

Thanks for getting back to me on this matter,
Martin

  reply	other threads:[~2009-12-14 19:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02 19:02 Org-mode version 6.32trans and 6.21b; Strange interaction between whitespace-mode and cust. org-ellipsis Martin Pohlack
2009-12-03  8:20 ` Carsten Dominik
2009-12-03 21:34   ` Martin Pohlack
2009-12-04 12:26     ` Carsten Dominik
2009-12-04 15:41       ` Martin Pohlack
2009-12-14 16:27         ` Carsten Dominik
2009-12-14 19:51           ` Martin Pohlack [this message]
2010-01-01 13:34             ` Carsten Dominik
  -- strict thread matches above, loose matches on Subject: below --
2009-12-02 19:06 Martin Pohlack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B269749.5030507@os.inf.tu-dresden.de \
    --to=mp26@os.inf.tu-dresden.de \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=viniciusjl@ig.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).