From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ryan C. Thompson" <rct@thompsonclan.org>
Subject: Bug Report: org-blocker-hook and org-trigger-hook are named
 incorrectly
Date: Fri, 27 Nov 2009 12:28:15 -0800
Message-ID: <4B10365F.4050404@thompsonclan.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NE7QY-0006dK-KY
	for emacs-orgmode@gnu.org; Fri, 27 Nov 2009 15:28:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NE7QU-0006bq-3R
	for emacs-orgmode@gnu.org; Fri, 27 Nov 2009 15:28:26 -0500
Received: from [199.232.76.173] (port=41092 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NE7QT-0006bn-U9
	for emacs-orgmode@gnu.org; Fri, 27 Nov 2009 15:28:21 -0500
Received: from mail-pz0-f181.google.com ([209.85.222.181]:33300)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rct@thompsonclan.org>) id 1NE7QT-0005HE-Jb
	for emacs-orgmode@gnu.org; Fri, 27 Nov 2009 15:28:21 -0500
Received: by pzk11 with SMTP id 11so1150889pzk.14
	for <emacs-orgmode@gnu.org>; Fri, 27 Nov 2009 12:28:18 -0800 (PST)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: org-mode Mailinglist <emacs-orgmode@gnu.org>

I believe it is the emacs convention to distinguish between hooks that 
take no arguments and hooks that do. Since org-blocker-hook and 
org-trigger-hook pass an argument to their functions, they should 
actually be called org-blocker-functions and org-trigger-functions.

 From the elisp info, 23.1 Hooks:

    If the hook variable's name does not end with `-hook', that
indicates it is probably an "abnormal hook".  That means the hook
functions are called with arguments, or their return values are used in
some way.  The hook's documentation says how the functions are called.
You can use `add-hook' to add a function to an abnormal hook, but you
must write the function to follow the hook's calling convention.
    By convention, abnormal hook names end in `-functions' or `-hooks'.
If the variable's name ends in `-function', then its value is just a
single function, not a list of functions.

-Ryan