From: Carsten Dominik <carsten.dominik@gmail.com>
To: "Tom Breton (Tehom)" <tehom@panix.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-html link building diff
Date: Tue, 18 May 2010 06:47:45 +0200 [thread overview]
Message-ID: <45F35E60-E0C4-4FF3-BBC4-F55F0B39BD90@gmail.com> (raw)
In-Reply-To: <d507214bdc2c8e3cc778b79e1e9655d1.squirrel@mail.panix.com>
On May 18, 2010, at 2:59 AM, Tom Breton (Tehom) wrote:
>
> Hi, Carsten. The new changes are pushed as
> tehom-html-export-refactor-build-link
>
> I couldn't undo the basing onto tehom-master, try though I might.
> Something to do with intermediate changes that I couldn't fast-forward
> and that I probably edited wrong. So I made a separate branch,
> tehom-html-export-refactor-build-link, which is now pushed to the
> repo. So tehom-master and html-export-refactor-build-link are already
> obsolete.
>
> I moved the tests into top-level directory testing, as you asked. I'm
> going to write a separate post describing the test conventions I use.
>
> Now a question: IIUC you want a branch that has no tests, that
> "contains only the changes that would go into org". Since I develop
> tests and code at about the same time (tests slightly before code),
> I'm not sure how to arrange the branching in a maintainable way.
Hi Tom,
If we decide to use your emtests framework for Org on a brader basis,
then there would be no reason to have a branch free of tests. This is
only necessary because I am supposed to apply your patches, but
without the testing framework at the moment.
Maybe we should just go ahead and start using emtest for Org-mode.
Why don't you go ahead and propose this in a mail to emacs-orgmode.
Lets see if there is any resistance by people who understand more
about testing than I do. If not, we go ahead and do it.
I would still prefer to have the tests in a separate directory if your
package allows to do so. Hope that this is no problem?
I guess all the emtest code itself would then have to go into the org-
mode git repo as well, so that we can use it?
And we should develop a make target that will run all tests.
- Carsten
>
> I could of course make a one-time branch that just removes the testing
> directory. But then what happens for any future fixes? Seems like
> each time I'd have to rebase that branch and pick thru changes and
> make it discard each change that deals with testing/. It seems hard
> to maintain.
>
> Tom Breton (Tehom)
>
>
- Carsten
next prev parent reply other threads:[~2010-05-18 4:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 22:24 org-html link building diff Tom Breton (Tehom)
2010-05-01 12:01 ` Carsten Dominik
2010-05-15 12:29 ` Carsten Dominik
2010-05-15 21:37 ` Tom Breton (Tehom)
2010-05-16 5:03 ` Carsten Dominik
2010-05-18 0:59 ` Tom Breton (Tehom)
2010-05-18 4:47 ` Carsten Dominik [this message]
2010-05-18 12:26 ` Sebastian Rose
2010-05-16 5:20 ` Carsten Dominik
2010-05-18 1:01 ` Test-file naming conventions - mine and suggested for org Tom Breton (Tehom)
2010-05-21 11:27 ` Carsten Dominik
2010-05-24 21:26 ` Proposal: Emtest as tester Tom Breton (Tehom)
2010-05-24 22:56 ` Dan Davison
2010-05-27 20:02 ` Tom Breton (Tehom)
2010-05-25 6:48 ` Carsten Dominik
2010-05-25 8:43 ` Martin Pohlack
2010-05-27 20:13 ` Tom Breton (Tehom)
2010-06-07 16:11 ` Benjamin Andresen
-- strict thread matches above, loose matches on Subject: below --
2010-04-18 2:13 org-html link building diff Tom Breton (Tehom)
2010-04-26 5:24 ` Carsten Dominik
2010-04-26 10:03 ` Sebastian Rose
2010-04-26 19:45 ` Tom Breton (Tehom)
2010-04-27 6:07 ` Carsten Dominik
2010-04-28 3:01 ` Tom Breton (Tehom)
2010-04-28 15:07 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F35E60-E0C4-4FF3-BBC4-F55F0B39BD90@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=tehom@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).