From: Carsten Dominik <carsten.dominik@gmail.com>
To: Daniel Clemente <n142857@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: faster agenda with properties support disabled (no org-refresh-properties)
Date: Tue, 3 Sep 2013 15:21:18 +0200 [thread overview]
Message-ID: <45F2826E-23F1-4414-ABF9-3E028A352B1E@gmail.com> (raw)
In-Reply-To: <87li3e2jv7.wl%n142857@gmail.com>
On Sep 3, 2013, at 2:02 PM, Daniel Clemente <n142857@gmail.com> wrote:
>
> Thank you.
> With this on, I reduced 1'7 seconds my normal agenda time (C-a a), from 13'5 to 11'8. Numbers are from elp but I checked them with an external stopwatch because sometimes I have the impression that elp makes things slower.
> The strange thing is, I don't see the difference I saw days before in (org-batch-agenda). I could reproduceably run a slow export (with no patch) and a fast export (with the patch). Now both are fast. I suppose that the contents of my agenda might have changed in a way that is fast to handle. Anyway, this is only good.
OK, I also have no idea why that happens.
Thanks for the feedback.
- Carsten
>
> El Sat, 31 Aug 2013 07:58:00 +0200 Carsten Dominik va escriure:
>>
>> Hi Daniel,
>>
>> I have implemented a different version of the patch. Please take a look at the new variable
>> org-agenda-ignore-drawer-properties.
>>
>> Regards, and thanks!
>>
>> - Carsten
>>
>> On 23.8.2013, at 11:24, Daniel Clemente <n142857@gmail.com> wrote:
>>
>>>>> So I would like to ask: is there a clean way to disable calls to
>>>>> org-refresh-properties?
>>>>
>>>> No, that would require a patch and a config variable.
>>>>
>>>> - Carsten
>>>>
>>>
>>> I send a patch to do this. Setting this new variable to t reduced 10
>>> seconds my agenda export time (down from 1 minute 6 seconds) as well
>>> as the update.
>>> You may add a comment about what to expect if your agenda depends on
>>> property data.
>>>
>>>
>>> diff --git a/lisp/org.el b/lisp/org.el
>>> index 572b797..167e7a8 100644
>>> --- a/lisp/org.el
>>> +++ b/lisp/org.el
>>> @@ -17656,6 +17656,14 @@ is not set, the tables are not re-aligned, etc."
>>> :version "24.3"
>>> :group 'org-agenda)
>>>
>>> +(defcustom org-agenda-ignore-properties nil
>>> + "Avoid updating text properties when building the agenda.
>>> +Properties are used for effort estimation, appointments, categories.
>>> +If you don't use these in the agenda, set it to t and it will be faster."
>>> + :type 'boolean
>>> + :version "24.3"
>>> + :group 'org-agenda)
>>> +
>>> (defun org-duration-string-to-minutes (s &optional output-to-string)
>>> "Convert a duration string S to minutes.
>>>
>>> @@ -18017,9 +18025,11 @@ When a buffer is unmodified, it is just
>>> killed. When modified, it is saved
>>> ;; this is only run for setting agenda tags from setup
>>> ;; file
>>> (org-set-regexps-and-options)))
>>> - (org-refresh-category-properties)
>>> - (org-refresh-properties org-effort-property 'org-effort)
>>> - (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime)
>>> + (unless org-agenda-ignore-properties
>>> + (org-refresh-category-properties)
>>> + (org-refresh-properties org-effort-property 'org-effort)
>>> + (org-refresh-properties "APPT_WARNTIME" 'org-appt-warntime)
>>> + )
>>> (setq org-todo-keywords-for-agenda
>>> (append org-todo-keywords-for-agenda org-todo-keywords-1))
>>> (setq org-done-keywords-for-agenda
>>>
>>
prev parent reply other threads:[~2013-09-03 13:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 20:25 Very slow performance in Org-mode on 10k line file? John Hendy
2013-08-07 21:39 ` Rainer Stengele
2013-08-07 21:47 ` John Hendy
2013-08-07 22:06 ` John Hendy
2013-08-07 22:12 ` Russell Adams
2013-08-07 22:17 ` John Hendy
2013-08-07 22:44 ` Russell Adams
2013-08-07 22:22 ` Nick Dokos
2013-08-07 22:24 ` John Hendy
2013-08-07 22:39 ` Nick Dokos
2013-08-07 23:02 ` John Hendy
2013-08-08 5:13 ` Achim Gratz
2013-08-12 3:43 ` faster agenda with properties support disabled (no org-refresh-properties) Daniel Clemente
2013-08-12 5:36 ` Carsten Dominik
2013-08-23 9:24 ` Daniel Clemente
2013-08-28 4:28 ` Samuel Wales
2013-08-28 8:28 ` Daniel Clemente
2013-08-31 5:58 ` Carsten Dominik
2013-08-31 6:22 ` Bastien
2013-09-02 5:09 ` Carsten Dominik
2013-09-02 10:54 ` Bastien
2013-09-03 12:02 ` Daniel Clemente
2013-09-03 13:21 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F2826E-23F1-4414-ABF9-3E028A352B1E@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=n142857@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).