From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Stanton <stanton@haas.berkeley.edu>
Subject: Re: Problem exporting to PDF (and viewing)
Date: Fri, 18 May 2012 13:56:19 -0700
Message-ID: <40C7B1BFC291ED4E9D10436D07736A33470478BC1E@EXMAIL7.haas.uc.berkeley.edu>
References: <40C7B1BFC291ED4E9D10436D07736A33470478B315@EXMAIL7.haas.uc.berkeley.edu>
	<CAHRqSkQzgfqR7rhq+EshCRrT+SC9PkCiCKapsSXEabrvR0L65A@mail.gmail.com>
	<23805.1336833570@alphaville>
	<40C7B1BFC291ED4E9D10436D07736A33470478B372@EXMAIL7.haas.uc.berkeley.edu>
	<31430.1336884795@alphaville>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:58664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stanton@haas.berkeley.edu>) id 1SVUEA-0007qp-Hg
	for emacs-orgmode@gnu.org; Fri, 18 May 2012 16:56:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stanton@haas.berkeley.edu>) id 1SVUE8-0006wA-Q9
	for emacs-orgmode@gnu.org; Fri, 18 May 2012 16:56:46 -0400
Received: from gateway-a.haas.berkeley.edu ([128.32.222.29]:40616)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stanton@haas.berkeley.edu>) id 1SVUE8-0006vy-LF
	for emacs-orgmode@gnu.org; Fri, 18 May 2012 16:56:44 -0400
In-Reply-To: <31430.1336884795@alphaville>
Content-Language: en-US
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: "nicholas.dokos@hp.com" <nicholas.dokos@hp.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>, Jonathan Leech-Pepin <jonathan.leechpepin@gmail.com>

> > 2) If not, where is the code that interprets %s? I can try stepping
> > through it and see what I can find.
> >
>=20
> It happens in org.el:org-open-file, specifically this piece of the code (=
I think):
>=20
> ,----
> |     (while (string-match "%s" cmd)
> | 	(setq cmd (replace-match
> | 		   (save-match-data
> | 		     (shell-quote-argument
> | 		      (convert-standard-filename file)))
> | 		   t t cmd)))
> `----

I did some tracing through, and have found where things go wrong.=20

At the start of the code listed above,=20

cmd =3D "c:/progra~1/sumatrapdf/sumatrapdf.exe %s"=20
file =3D "c:/dropbox/org/personal.pdf"

(convert-standard-filename file) returns
"C:/dropbox/org/personal.pdf"

So far so good...

However,=20

(shell-quote-argument (convert-standard-filename file)) returns
"c\\:dropbox/org/personal.pdf"

That's where the problem occurs. After this block of code is completed, cmd=
 takes the value
"c:/progra~1/sumatrapdf/sumatrapdf.exe c\\:dropbox/org/personal.pdf"

This command causes sumatrapdf to squawk with an error. It's the "\\:" that=
 causes the problem. If, after this block of code executes, I manually swit=
ch the "\\:" back to ":/", so cmd goes back to=20

"c:/progra~1/sumatrapdf/sumatrapdf.exe c:/dropbox/org/personal.pdf"

and then press "c" to continue, the PDF file pops up just fine. Could we ju=
st drop the call to shell-quote-argument? It seems like everything would wo=
rk fine without this call.