From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Re: Bug: Invalid face reference Date: Fri, 29 Feb 2008 21:46:40 +0100 Message-ID: <3C6351DB-D627-4948-B9A2-2EB66DB1D77A@science.uva.nl> References: <47C5F369.10206@gmail.com> <87wsop6f4p.fsf@bzg.ath.cx> <47C617B0.90801@gmail.com> <47C6E374.2050401@gmail.com> <47C83EB8.50302@gmail.com> <47C851EC.7000500@gmail.com> <8F0F696D-0C50-4DE7-9E2B-C5F52A63175C@gmail.com> <47C86EBC.5070303@gmail.com> Mime-Version: 1.0 (Apple Message framework v919.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JVC7z-0000wq-3l for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 15:46:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JVC7y-0000wO-7h for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 15:46:46 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JVC7y-0000wH-1a for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 15:46:46 -0500 Received: from ug-out-1314.google.com ([66.249.92.169]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JVC7x-0002vX-K2 for emacs-orgmode@gnu.org; Fri, 29 Feb 2008 15:46:45 -0500 Received: by ug-out-1314.google.com with SMTP id a2so499792ugf.48 for ; Fri, 29 Feb 2008 12:46:44 -0800 (PST) In-Reply-To: <47C86EBC.5070303@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Wanrong Lin Cc: emacs-orgmode@gnu.org OK, thanks. - Carsten On Feb 29, 2008, at 9:44 PM, Wanrong Lin wrote: > > I already did so. So far there is no problem. If I don't report > anything, I think you can assume in the next release that I have no > problem at all with the htmlize advice removed. > > Wanrong > > Carsten Dominik wrote: >> I am taking this patch thanks! >> >> This might indeed make the advice for htmlize unnecessary - could >> you please >> remove it your own setup and test this for a long while? And then >> report back? >> >> Thanks! >> >> - Carsten >> >> On Feb 29, 2008, at 7:41 PM, Wanrong Lin wrote: >> >>> Found the bug and fixed it as following (see the comment line >>> marked with ) >>> ------------- >>> (defun org-agenda-align-tags (&optional line) >>> "Align all tags in agenda items to `org-agenda-tags-column'." >>> (let ((inhibit-read-only t) l c) >>> (save-excursion >>> (goto-char (if line (point-at-bol) (point-min))) >>> (while (re-search-forward (org-re "\\([ \t]+\\)\\(: >>> [[:alnum:]_@:]+:\\)[ \t]*$") >>> (if line (point-at-eol) nil) t) >>> (add-text-properties >>> (match-beginning 2) (match-end 2) >>> ;; : bug fix against 5.22a >>> (list 'face (delq nil (list 'org-tag (get-text-property >>> (match-beginning 2) >>> 'face))))) >>> (setq l (- (match-end 2) (match-beginning 2)) >>> c (if (< org-agenda-tags-column 0) >>> (- (abs org-agenda-tags-column) l) >>> org-agenda-tags-column)) >>> (delete-region (match-beginning 1) (match-end 1)) >>> (goto-char (match-beginning 1)) >>> (insert (org-add-props >>> (make-string (max 1 (- c (current-column))) ?\ ) >>> (text-properties-at (point)))))))) >>> >>> >>> Wanrong Lin wrote: >>>> More update: >>>> >>>> In a tag search result buffer, I move the cursor to a tag, and >>>> eval (get-text-property (point) 'face), and I get: (org-tag >>>> nil). So this "nil" is causing the problem, but I don't know >>>> where it is sneaked in. >>>> >>>> Wanrong >>>> >>>>> Just some update: >>>>> >>>>> I called (org-restart-font-lock) function inside my tag search >>>>> result buffer, and I can see a new "Invalid face reference: nil >>>>> [X times]" message is generated in the "*Messages*" buffer, with >>>>> "X" keeps increasing. I have "jit-lock-mode" (Just in time font >>>>> locking) enabled in my emacs config, so I guess that ticking "X" >>>>> number is from the background font locking process. >>>>> >>>>> It seems something is wrong with font locking for tags. But this >>>>> only happens in tag search result buffer. It does not happen in >>>>> regular agenda buffer. >>>>> >>>>> I don't know how to proceed to pin-point this. Can any of you >>>>> guys also reproduce this? Any suggestions? Thank you. >>>>> >>>>> Wanrong >>>>> >>>>> >>>> >>>> >>> >>> >>> >>> _______________________________________________ >>> Emacs-orgmode mailing list >>> Remember: use `Reply All' to send replies to the list. >>> Emacs-orgmode@gnu.org >>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode >> > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode