From: "Galen Menzel" <galen.menzel@utexas.edu>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix two false failures in org's test suite
Date: Thu, 10 Aug 2017 10:58:00 -0700 [thread overview]
Message-ID: <38D8B898-1E62-4916-AD55-DA42DE5D7CA7@utexas.edu> (raw)
In-Reply-To: <87y3qr9186.fsf@nicolasgoaziou.fr>
Hi Nicolas,
On 10 Aug 2017, at 3:16, Nicolas Goaziou wrote:
>> - (lambda () '(22353 6425 905205 644000))))
>> + (lambda ()
>> + (apply #'encode-time
>> + (org-parse-time-string "2016-06-03 Fri 01:43")))))
>
> Shouldn't this be
>
> (org-parse-time-string "..." nil t)
>
> to force UTC?
I don't believe so.
org-deadline-close-p interprets its timestamp-string argument as being
in the local time zone (i.e., the call to encode-time that results from
calling org-deadline-close-p always has a nil zone argument). Since we
are using "2016-06-03 Fri 01:43" as the ersatz current time to check if
deadlines are close, then "2016-06-03 Fri 01:43" should be in the local
time zone as well.
As I would expect, forcing UTC here makes the test fail on my machine.
Best,
Galen
next prev parent reply other threads:[~2017-08-10 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 22:37 [PATCH] Fix two false failures in org's test suite Galen Menzel
2017-08-10 10:16 ` Nicolas Goaziou
2017-08-10 17:58 ` Galen Menzel [this message]
2017-08-10 20:46 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38D8B898-1E62-4916-AD55-DA42DE5D7CA7@utexas.edu \
--to=galen.menzel@utexas.edu \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).