emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: JD Smith <jdtsmith@gmail.com>
To: emacs-orgmode@gnu.org
Subject: org-src-font-lock-fontify-block  is unaware of org-edit-src-content-indentation, leading to fontification issues
Date: Sun, 12 Nov 2023 10:39:09 -0500	[thread overview]
Message-ID: <371CA9D8-B187-43BF-B6BE-B2122627C068@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

When `org-edit-src-content-indentation’ is non-nil (default: 2), editing SRC blocks preserves this amount of extra indentation space at the beginning of each line of the block, removing and then re-adding it on round trips through `org-edit-src-code’.

But `org-src-font-lock-fontify-block' does not consider this extra space. Instead it simply copies the full block verbatim into e.g.  *org-src-fontification:python-mode*, as if the extra indent space were a legitimate part of the source.  Normally this wouldn’t be a problem, as faces are attached to keywords.  But for any fontification that depends explicitly on indentation, this leads to incorrect results.  For example, my indent-bars package adds indentation bars via text properties based on absolute column position.  These bars are then offset in the displayed org src block by 2 columns from their correct locations, due to the extra space org has put there.

A sensible solution might be for fontify-block to strip `org-edit-src-content-indentation’ worth of space from the beginning of each line, just as is done for src block editing, then perform the fontification, then add that space back to the fontified text for display.

Thanks for all your work on org.

[-- Attachment #2: Type: text/html, Size: 1902 bytes --]

             reply	other threads:[~2023-11-12 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-12 15:39 JD Smith [this message]
2023-11-13  8:37 ` org-src-font-lock-fontify-block is unaware of org-edit-src-content-indentation, leading to fontification issues Ihor Radchenko
2023-11-13 12:25   ` JD Smith
2023-11-13 12:30     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=371CA9D8-B187-43BF-B6BE-B2122627C068@gmail.com \
    --to=jdtsmith@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).