From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Fix agenda bulk refile bug Date: Wed, 26 Aug 2009 16:49:28 +0200 Message-ID: <36A91EF9-AD4F-4152-9C9A-5090A32FCF9E@gmail.com> References: <97F810D1-4F60-40E7-8DAB-D816F27310E4@gmail.com> <1251297334-10504-1-git-send-email-bernt@norang.ca> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MgJom-0000dh-Aq for emacs-orgmode@gnu.org; Wed, 26 Aug 2009 10:49:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MgJoh-0000V3-Nh for emacs-orgmode@gnu.org; Wed, 26 Aug 2009 10:49:43 -0400 Received: from [199.232.76.173] (port=50294 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MgJoh-0000Up-Hz for emacs-orgmode@gnu.org; Wed, 26 Aug 2009 10:49:39 -0400 Received: from mail-ew0-f208.google.com ([209.85.219.208]:44543) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MgJof-0005uQ-Ok for emacs-orgmode@gnu.org; Wed, 26 Aug 2009 10:49:38 -0400 Received: by ewy4 with SMTP id 4so261341ewy.3 for ; Wed, 26 Aug 2009 07:49:36 -0700 (PDT) In-Reply-To: <1251297334-10504-1-git-send-email-bernt@norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org Applied, thanks. - Carsten On Aug 26, 2009, at 4:35 PM, Bernt Hansen wrote: > Fix bulk refiling in the agenda due to commit > 9ec5529 (Fix jumping to last refile location in agenda, 2009-08-20) > > This restores the original behaviour. > --- > This patch is available in git://git.norang.ca/org-mode for-carsten > > As it turns out the revert of the previous patch generated conflicts > and I reverted it incorrectly :-P. The following patch applied on top > of master seems to fix the problem. > > Bernt > > lisp/org-agenda.el | 17 ++++++++--------- > 1 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 84d6566..d915e46 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -5481,18 +5481,17 @@ If this information is not given, the > function uses the tree at point." > (org-agenda-error))) > (buffer (marker-buffer marker)) > (pos (marker-position marker)) > - (rfloc)) > - (setq rfloc (or rfloc > + (rfloc (or rfloc > (org-refile-get-location > (if goto "Goto: " "Refile to: ") buffer > org-refile-allow-creating-parent-nodes)))) > - (with-current-buffer buffer > - (save-excursion > - (save-restriction > - (widen) > - (goto-char marker) > - (org-remove-subtree-entries-from-agenda) > - (org-refile goto buffer rfloc)))))) > + (with-current-buffer buffer > + (save-excursion > + (save-restriction > + (widen) > + (goto-char marker) > + (org-remove-subtree-entries-from-agenda) > + (org-refile goto buffer rfloc))))))) > > (defun org-agenda-open-link (&optional arg) > "Follow the link in the current line, if any. > -- > 1.6.4.1.331.gda1d56 > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode