From: Carsten Dominik <carsten.dominik@gmail.com>
To: David Maus <dmaus@ictsoc.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: [bug] org-link-escape and (wrong-type-argument stringp nil)
Date: Wed, 29 Sep 2010 17:48:04 +0200 [thread overview]
Message-ID: <33DDDFB0-E2DF-43CE-B307-85032F92B03A@gmail.com> (raw)
In-Reply-To: <1285565761-7558-1-git-send-email-dmaus@ictsoc.de>
Hi David,
I have not have time to follow this in detail, but if you feel
confident that this is
doing the right thing, pleas go ahead and apply the necessary
patches. I am an encoding moron, so I am easily convinced that you
and Sebastian together cook up something useful. :-)
- Carsten
On Sep 27, 2010, at 7:36 AM, David Maus wrote:
>> Also I guess the decoding is secure. Means we could change the
>> comment of this function:
>
>> (defun org-protocol-unhex-compound (hex)
>> "Unhexify unicode hex-chars. E.g. `%C3%B6' is the German Umlaut `ö'.
>> Note: this function falls back on single byte decoding if a
>> character sequence is not valid utf-8.
>> See `org-protocol-unhex-single-byte-sequence'."
>
>
>> Should I send another patch against master? (Too late here... for
>> me...)
>
> Not necessary, following patch removed this sentence and added a
> proper commit message (please see: Commit messages and ChangeLog
> entries on http://orgmode.org/worg/org-contribute.php).
>
> I took the new patch "under review" in patchtracker -- If someone else
> wants to jump on it, just go ahead.
>
> Best,
> -- David
>
> Sebastian Rose (1):
> Decode single byte sequence if decoding unicode failed.
>
> lisp/org-protocol.el | 26 +++++++++++++++++++++++---
> 1 files changed, 23 insertions(+), 3 deletions(-)
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2010-09-29 15:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 12:42 [bug] org-link-escape and (wrong-type-argument stringp nil) Sébastien Vauban
2010-09-20 18:57 ` David Maus
2010-09-20 19:31 ` Sebastian Rose
2010-09-22 7:19 ` David Maus
2010-09-22 14:25 ` Sebastian Rose
2010-09-23 18:40 ` David Maus
2010-09-23 19:57 ` Sebastian Rose
2010-09-26 18:22 ` David Maus
2010-09-26 21:23 ` Sebastian Rose
2010-09-26 22:43 ` Sebastian Rose
2010-09-26 22:47 ` Sebastian Rose
2010-09-26 22:51 ` Sebastian Rose
2010-09-27 5:36 ` [PATCH] " David Maus
2010-09-27 12:43 ` Sebastian Rose
2010-09-29 15:48 ` Carsten Dominik [this message]
2010-09-27 5:36 ` [PATCH] Decode single byte sequence if decoding unicode failed David Maus
2010-11-04 20:35 ` [bug] org-link-escape and (wrong-type-argument stringp nil) David Maus
2010-09-20 19:49 ` Sébastien Vauban
2010-09-22 7:20 ` David Maus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33DDDFB0-E2DF-43CE-B307-85032F92B03A@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).