From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH 1/2] respect startgroup/endgroup delimiters with description in org-tag-alist Date: Thu, 5 Nov 2009 16:12:15 +0100 Message-ID: <30A81012-8AD0-43D1-B5A9-AA0878E033FC@gmail.com> References: <1257415055-8120-1-git-send-email-drmabuse@cs.tu-berlin.de> Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N640i-00043i-3w for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 10:12:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N640d-0003wh-62 for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 10:12:27 -0500 Received: from [199.232.76.173] (port=48528 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N640c-0003wE-TD for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 10:12:22 -0500 Received: from ey-out-1920.google.com ([74.125.78.144]:63427) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N640c-0004rV-Bd for emacs-orgmode@gnu.org; Thu, 05 Nov 2009 10:12:22 -0500 Received: by ey-out-1920.google.com with SMTP id 3so37474eyh.34 for ; Thu, 05 Nov 2009 07:12:18 -0800 (PST) In-Reply-To: <1257415055-8120-1-git-send-email-drmabuse@cs.tu-berlin.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Stephan Schmitt Cc: emacs-orgmode@gnu.org Applied, thanks. - Carsten On Nov 5, 2009, at 10:57 AM, Stephan Schmitt wrote: > org-agenda-filter-by-tag and org-get-current-options didn't account > for > radio group delimiters in org-tag-alist where a description is > attached > as second item of the list: > > ((:startgroup "context") > ("Work" . 87) > ("Home" . 72) > ("Errand" . 69) > (:endgroup) > (:newline) > (:startgroup "communication") > ("Mail" . 77) > ("Call" . 67) > (:endgroup) > (:newline) > ...) > --- > lisp/org-agenda.el | 5 ++++- > lisp/org-exp.el | 5 +++-- > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 5e0f4fd..6e90f6f 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -5094,7 +5094,10 @@ to switch to narrowing." > (interactive "P") > (let* ((alist org-tag-alist-for-agenda) > (tag-chars (mapconcat > - (lambda (x) (if (cdr x) (char-to-string (cdr x)) "")) > + (lambda (x) (if (and (not (symbolp (car x))) > + (cdr x)) > + (char-to-string (cdr x)) > + "")) > alist "")) > (efforts (org-split-string > (or (cdr (assoc (concat org-effort-property "_ALL") > diff --git a/lisp/org-exp.el b/lisp/org-exp.el > index a71f081..cef29b7 100644 > --- a/lisp/org-exp.el > +++ b/lisp/org-exp.el > @@ -2750,8 +2750,9 @@ Does include HTML export options as well as > TODO and CATEGORY stuff." > ((not org-log-done) "nologdone")) > (or (mapconcat (lambda (x) > (cond > - ((equal '(:startgroup) x) "{") > - ((equal '(:endgroup) x) "}") > + ((equal :startgroup (car x)) "{") > + ((equal :endgroup (car x)) "}") > + ((equal :newline (car x)) "") > ((cdr x) (format "%s(%c)" (car x) (cdr x))) > (t (car x)))) > (or org-tag-alist (org-get-buffer-tags)) " ") "") > -- > 1.6.4.4 > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode - Carsten