* [2024-12-13 18:46] Ihor Radchenko: > Phil Estival writes: > >> this patch modifies ob-sql to add support for session. > > Before I start a more detailed preview, may you please: > > 1. Rebase your changes onto main (development) branch. This is where the > new features are added. See https://orgmode.org/worg/org-maintenance.html#branches > 2. Get rid of whitespace-only commits. See https://orgmode.org/worg/org-contribute.html#orge765e69 > 3. If possible, add a commit message to each patch in the series. It > will make things easier for me during the review, as I will have an > idea about the general purpose of each patch in the series. > Hello. Here we go again. Also, in the commit message of the patch for the tests, I mention that some macros should probably be moved upward in a file where generic functions which purposes are to help writing the tests of babel source blocks should be declared (ob-src-testfuncs.el for instance). Examples : - result-should-contain (regexp block) : Checking that REGEXP(s) matches the command executed when evaluating BLOCK. - result-should-not-contain (regexp block) - result-equals (str block) and so on. Cheers, Phil