From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viktor Rosenfeld Subject: org-agenda-filter-by-tag-refine defaults to exclude Date: Tue, 5 Jan 2016 08:42:20 +0100 Message-ID: <29B5D2C5-E59B-4E8D-9669-67F24C0B7C60@gmx.de> Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Content-Type: multipart/signed; boundary="Apple-Mail=_1BE05E33-6B02-44B7-9466-EB8ABB3F7A35"; protocol="application/pgp-signature"; micalg=pgp-sha1 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGMGF-0003et-FP for emacs-orgmode@gnu.org; Tue, 05 Jan 2016 02:42:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGMGB-0000zh-Dz for emacs-orgmode@gnu.org; Tue, 05 Jan 2016 02:42:31 -0500 Received: from mout.gmx.net ([212.227.15.19]:65405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGMGB-0000zT-4I for emacs-orgmode@gnu.org; Tue, 05 Jan 2016 02:42:27 -0500 Received: from kenny.fritz.box ([2.247.65.8]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MePYV-1aaM5n16op-00QCjf for ; Tue, 05 Jan 2016 08:42:24 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --Apple-Mail=_1BE05E33-6B02-44B7-9466-EB8ABB3F7A35 Content-Type: multipart/alternative; boundary="Apple-Mail=_FCCBB9E3-E3FB-4985-A5EE-63CA181FA89B" --Apple-Mail=_FCCBB9E3-E3FB-4985-A5EE-63CA181FA89B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi, I noticed that org-agenda-filter-by-tag-refine started to exclude = selected tags by default recently because the 'refine in the call to = org-agenda-filter-by-tag is interpreted as an exclude flag. The attached = patch fixes this. However, it seems that the function is superfluous because = org-agenda-filter-by-tag can filter on multiple tags as well if called = multiple times (that used not to be the case earlier). So maybe it = should be deprecated and removed? Best, Viktor diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index d91b64d..21928de 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -7580,7 +7580,7 @@ to switch between filtering and excluding." (defun org-agenda-filter-by-tag-refine (arg &optional char) "Refine the current filter. See `org-agenda-filter-by-tag'." (interactive "P") - (org-agenda-filter-by-tag arg char 'refine)) + (org-agenda-filter-by-tag arg char)) (defun org-agenda-filter-make-matcher (filter type &optional expand) "Create the form that tests a line for agenda filter. Optional --Apple-Mail=_FCCBB9E3-E3FB-4985-A5EE-63CA181FA89B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Hi,

I = noticed that org-agenda-filter-by-tag-refine started to exclude selected = tags by default recently because the 'refine in the call to = org-agenda-filter-by-tag is interpreted as an exclude flag. The attached = patch fixes this.

However, it seems that the function is superfluous = because org-agenda-filter-by-tag can filter on multiple tags as = well if called multiple times (that used not to be the case earlier). So = maybe it should be deprecated and removed?

Best,

Viktor

diff --git = a/lisp/org-agenda.el b/lisp/org-agenda.el

index d91b64d..21928de 100644

--- a/lisp/org-agenda.el

+++ b/lisp/org-agenda.el

@@ -7580,7 +7580,7 = @@ to switch between filtering and excluding."

(defun org-agenda-filter-by-tag-refine (arg = &optional char)

= "Refine the current filter. See = `org-agenda-filter-by-tag'."

= (interactive "P")

- (org-agenda-filter-by-tag arg char = 'refine))

+ = (org-agenda-filter-by-tag arg char))

(defun org-agenda-filter-make-matcher (filter = type &optional expand)

= "Create the form that tests a line for agenda filter. = Optional

= --Apple-Mail=_FCCBB9E3-E3FB-4985-A5EE-63CA181FA89B-- --Apple-Mail=_1BE05E33-6B02-44B7-9466-EB8ABB3F7A35 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- iD8DBQFWi3PekWI06CMxQ0ARAvrtAKCTLa1QjB+2sFknx8QPvT8fUJdg7wCfQfQh DJc5xpaLtwxb3QUUzRzfCeo= =prbS -----END PGP SIGNATURE----- --Apple-Mail=_1BE05E33-6B02-44B7-9466-EB8ABB3F7A35--