[PATCH 2/2] Do not issue the 'task should be finished by now' message if the clock is stopped

[PATCH 2/2] Do not issue the 'task should be finished by now' message if the clock is stopped

[Bernt Hansen]

This patch prevents the org-clock-sound notification and the

   "Task'BLAH' should be finished by now."

message when the termination time is reached and the clock is not
running.

Before this patch spurious notifications and messages were generated when
clocking in a task with estimated effort time remaining.  After clocking
out the task the remaining minutes would tick by and then the sound
and message that the task should be finished were generated - even though
you are not working on it anymore.
---
This patch series is available at git://git.norang.ca/org-mode for-carsten

 lisp/org-clock.el |   21 +++++++++++----------
 1 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 57f1a6f..ace7792 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -369,16 +369,17 @@ previous clocking intervals."
 (defun org-clock-notify-once-if-expired ()
   "Show notification if we spent more time then we estimated before.
 Notification is shown only once."
-  (let ((effort-in-minutes (org-hh:mm-string-to-minutes org-clock-effort))
-	(clocked-time (org-clock-get-clocked-time)))
-    (if (>= clocked-time effort-in-minutes)
-	(unless org-clock-notification-was-shown
-	  (setq org-clock-notification-was-shown t)
-	  (org-clock-play-sound)
-	  (org-show-notification
-	   (format "Task '%s' should be finished by now. (%s)"
-		   org-clock-heading org-clock-effort)))
-      (setq org-clock-notification-was-shown nil))))
+  (when (marker-buffer org-clock-marker)
+    (let ((effort-in-minutes (org-hh:mm-string-to-minutes org-clock-effort))
+	  (clocked-time (org-clock-get-clocked-time)))
+      (if (>= clocked-time effort-in-minutes)
+	  (unless org-clock-notification-was-shown
+	    (setq org-clock-notification-was-shown t)
+	    (org-clock-play-sound)
+	    (org-show-notification
+	     (format "Task '%s' should be finished by now. (%s)"
+		     org-clock-heading org-clock-effort)))
+	(setq org-clock-notification-was-shown nil)))))
 
 (defun org-show-notification (notification)
   "Show notification. Use libnotify, if available."
-- 
1.6.3.2.198.g6096d

Re: [PATCH 2/2] Do not issue the 'task should be finished by now' message if the clock is stopped

[Carsten Dominik]

All patches applied, thanks.

- Carsten

On Jun 9, 2009, at 10:43 PM, Bernt Hansen wrote:

> This patch prevents the org-clock-sound notification and the
>
>   "Task'BLAH' should be finished by now."
>
> message when the termination time is reached and the clock is not
> running.
>
> Before this patch spurious notifications and messages were generated  
> when
> clocking in a task with estimated effort time remaining.  After  
> clocking
> out the task the remaining minutes would tick by and then the sound
> and message that the task should be finished were generated - even  
> though
> you are not working on it anymore.
> ---
> This patch series is available at git://git.norang.ca/org-mode for- 
> carsten
>
> lisp/org-clock.el |   21 +++++++++++----------
> 1 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 57f1a6f..ace7792 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -369,16 +369,17 @@ previous clocking intervals."
> (defun org-clock-notify-once-if-expired ()
>   "Show notification if we spent more time then we estimated before.
> Notification is shown only once."
> -  (let ((effort-in-minutes (org-hh:mm-string-to-minutes org-clock- 
> effort))
> -	(clocked-time (org-clock-get-clocked-time)))
> -    (if (>= clocked-time effort-in-minutes)
> -	(unless org-clock-notification-was-shown
> -	  (setq org-clock-notification-was-shown t)
> -	  (org-clock-play-sound)
> -	  (org-show-notification
> -	   (format "Task '%s' should be finished by now. (%s)"
> -		   org-clock-heading org-clock-effort)))
> -      (setq org-clock-notification-was-shown nil))))
> +  (when (marker-buffer org-clock-marker)
> +    (let ((effort-in-minutes (org-hh:mm-string-to-minutes org-clock- 
> effort))
> +	  (clocked-time (org-clock-get-clocked-time)))
> +      (if (>= clocked-time effort-in-minutes)
> +	  (unless org-clock-notification-was-shown
> +	    (setq org-clock-notification-was-shown t)
> +	    (org-clock-play-sound)
> +	    (org-show-notification
> +	     (format "Task '%s' should be finished by now. (%s)"
> +		     org-clock-heading org-clock-effort)))
> +	(setq org-clock-notification-was-shown nil)))))
>
> (defun org-show-notification (notification)
>   "Show notification. Use libnotify, if available."
> -- 
> 1.6.3.2.198.g6096d
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode