From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?R=FCdiger?= Sonderfeld <ruediger@c-plusplus.de>
Subject: Re: [PATCH 2/3] org-datetree.el: Add support for ISO week trees.
Date: Thu, 03 Sep 2015 01:14:43 +0100
Message-ID: <2604417.dNsH2en53f@descartes>
References: <cover.1441180730.git.ruediger@c-plusplus.net>
	<5814117.7UzEcaoqyZ@descartes> <87oahk8ug6.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33175)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ruediger@c-plusplus.de>) id 1ZXIB9-0008QD-4V
	for emacs-orgmode@gnu.org; Wed, 02 Sep 2015 20:14:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ruediger@c-plusplus.de>) id 1ZXIB5-0004dk-3v
	for emacs-orgmode@gnu.org; Wed, 02 Sep 2015 20:14:59 -0400
Received: from ptmx.org ([178.63.28.110]:57206)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ruediger@c-plusplus.de>) id 1ZXIB4-0004dQ-UP
	for emacs-orgmode@gnu.org; Wed, 02 Sep 2015 20:14:55 -0400
In-Reply-To: <87oahk8ug6.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org, =?ISO-8859-1?Q?R=FCdiger?= Sonderfeld <ruediger@c-plusplus.net>

On Wednesday 02 September 2015 21:58:17 Nicolas Goaziou wrote:
> R=C3=BCdiger Sonderfeld <ruediger@c-plusplus.net> writes:
> > +    (let ((prop (org-find-property "DATE_WEEK_TREE")))
>=20
> I don't think we need to introduce a new property for that. DATE_TREE=
 is
> enough.

Since DATE_TREE and DATE_WEEK_TREE (or WEEK_TREE instead?) are structur=
ed=20
differently it might make sense to keep the property separated.

> > +      ;; ISO 8601 week format is %G-W%V(-%u)
> > +      (org-datetree--find-create "^\\*+[
> > \t]+\\([12][0-9]\\{3\\}\\)\\(\\s-*?\\([
> > \t]:[[:alnum:]:_@#%%]+:\\)?\\s-*$\\)"
> Isn't this line too long?

What's the limit?  Because if it's 80 char then I'd need to do some `co=
ncat'=20
ugliness because the regex is over 80 char long.

I've fixed the rest and will send updated patches.

Cheers,

R=C3=BCdiger