From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: Export options being ignored Date: Thu, 05 May 2011 01:08:14 -0400 Message-ID: <24788.1304572094@alphaville.dokosmarshall.org> References: <24377.1304570014@alphaville.dokosmarshall.org> Reply-To: nicholas.dokos@hp.com Return-path: Received: from eggs.gnu.org ([140.186.70.92]:34203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHrk9-0007c8-31 for emacs-orgmode@gnu.org; Thu, 05 May 2011 02:08:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHrk5-0007ra-42 for emacs-orgmode@gnu.org; Thu, 05 May 2011 02:08:56 -0400 Received: from vms173001pub.verizon.net ([206.46.173.1]:51237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHrk4-0007rS-Vd for emacs-orgmode@gnu.org; Thu, 05 May 2011 02:08:53 -0400 Received: from alphaville.dokosmarshall.org ([unknown] [173.76.32.106]) by vms173001.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0LKP00AT0I9QPY70@vms173001.mailsrvcs.net> for emacs-orgmode@gnu.org; Thu, 05 May 2011 00:08:32 -0500 (CDT) In-reply-to: Message from Nick Dokos of "Thu, 05 May 2011 00:33:34 EDT." <24377.1304570014@alphaville.dokosmarshall.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Cc: Lawrence Mitchell , nicholas.dokos@hp.com, emacs-orgmode@gnu.org, Eden Cardim Nick Dokos wrote: > ,---- > | aa6dba8a74016587755c250bb8cc4743a4082ea1 is the first bad commit > `---- > Taking a look at the commit: ,---- | commit aa6dba8a74016587755c250bb8cc4743a4082ea1 | Author: Lawrence Mitchell | Date: Thu Jan 20 18:23:22 2011 +0000 | | Only match complete words in org-export-add-options-to-plist | | * org-exp.el (org-export-add-options-to-plist): Require match to start | at a word-boundary. | | Previously, if an option was the suffix of another option (such as TeX | and LaTeX) the setting for the former would propagator to the latter. | This seems like an unintended consequence of a lax regexp in | org-export-add-options-to-plist. This patch allows options to share a | suffix with another option by requiring that the match against an | option starts at a word-boundary. | | diff --git a/lisp/org-exp.el b/lisp/org-exp.el | index a265c3b..4a10303 100644 | --- a/lisp/org-exp.el | +++ b/lisp/org-exp.el | @@ -830,7 +830,7 @@ security risks." | (let ((op org-export-plist-vars)) | (while (setq o (pop op)) | (if (and (nth 1 o) | - (string-match (concat (regexp-quote (nth 1 o)) | + (string-match (concat "\\<" (regexp-quote (nth 1 o)) | ":\\([^ \t\n\r;,.]*\\)") | options)) | (setq p (plist-put p (car o) `---- explains the problem: \< matches the empty string at the beginning of a word (i.e. if the syntax class of the next character is "word") but it does not at the beginning of a char that is of some other syntax class (I think it will not match anything in this case). So Eden diagnosed it correctly: it *is* a parsing problem and it *does* involve the non-word options. At this point, the cure looks worse than the disease, so this commit should probably be reverted. Thanks, Nick