From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MIXjNLnTgF/lLQAA0tVLHw (envelope-from ) for ; Fri, 09 Oct 2020 21:18:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id AMC0MLnTgF8oZAAA1q6Kng (envelope-from ) for ; Fri, 09 Oct 2020 21:18:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 636759400EF for ; Fri, 9 Oct 2020 21:18:49 +0000 (UTC) Received: from localhost ([::1]:52092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQzmq-0000UM-CM for larch@yhetil.org; Fri, 09 Oct 2020 17:18:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQzlr-0000Sk-AU for emacs-orgmode@gnu.org; Fri, 09 Oct 2020 17:17:47 -0400 Received: from box.hyperreal.enterprises ([2a01:7e00::f03c:91ff:fe8c:3957]:52127) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQzlo-0007cV-Jn for emacs-orgmode@gnu.org; Fri, 09 Oct 2020 17:17:47 -0400 Received: from authenticated-user (box.hyperreal.enterprises [85.159.211.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.hyperreal.enterprises (Postfix) with ESMTPSA id B905A3EFCC; Fri, 9 Oct 2020 22:17:39 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hyperreal.enterprises; s=mail; t=1602278259; bh=0uoM6QtNh70pA5pbBpchnExILQZ7FGMnp2zczid14uw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nmJde8zz+tUasAYwXiR8OIcF65T7siWJ58LCxm3wB56vlc6FUNQf4cv5i44TE6EmV 2N8mI5G/shaYQQtP4zzbtqmKJuKLJU1GupRi4E5qtkwQwRLaxMV/JR8LYLIaaovWw6 1HQmXBhCmOVSiPZK1Cyt5Z311yhHHELO2FgnWQmqnEcKymEQ1W7ofI5i4TLdPDQr0d OXfSF460A36Qxg6FdSdDEdMhcPS7CQQt/UiylqNKFl+SDh56Jj6hUUMkBAgsbzr9Ck 3FaVD9gyL4J/luTDKjOV26Dv/liNClB3U8P09BASQdtwnV2Wu3fvNgwIFP5RIny+ul svQ/zBdAlp2Fw== MIME-Version: 1.0 Date: Fri, 09 Oct 2020 22:17:39 +0100 To: Ag Ibragimov Cc: emacs-orgmode Subject: Re: patch: ob-clojure improvements In-Reply-To: References: Message-ID: <227c9d17b3c8083eb5b605fa608cf9bc@hyperreal.enterprises> X-Sender: joseph.corneli.orgmode@hyperreal.enterprises Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:7e00::f03c:91ff:fe8c:3957; envelope-from=joseph.corneli.orgmode@hyperreal.enterprises; helo=box.hyperreal.enterprises X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" Reply-to: joseph.corneli.orgmode@hyperreal.enterprises From: joseph.corneli.orgmode--- via "General discussions about Org-mode." X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=hyperreal.enterprises header.s=mail header.b=nmJde8zz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: KWowt+2GsKXo Nice work, I did some testing here... * Comment: Should babashka be added as an option for custom? (defcustom org-babel-clojure-backend nil "Backend used to evaluate Clojure code blocks." :group 'org-babel :type '(choice (const :tag "inf-clojure" inf-clojure) (const :tag "cider" cider) (const :tag "slime" slime) (const :tag "Not configured yet" nil))) * I wonder if there’s something wrong here? ... Inside ‘ob-clojure-eval-with-cider’ (push (or (nrepl-dict-get response "root-ex") (nrepl-dict-get response "ex") (nrepl-dict-get response (if (or (member "output" result-params) (member "pp" result-params)) "out" "value"))) result0) That didn’t work for me, using an instance of Cider *connected to babashka*. But it did work when I swapped "value" and "out"! - Testing code and inspecting with edebug: #+begin_src clojure :backend cider :results output (range 10) #+end_src * Lastly, the documentation and implementation have drifted apart...? https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-clojure.html Ag Ibragimov writes: > Hi everyone, here's my attempt to add clojure CLI and babashka support > for ob-clojure.el > > - Adds a header parameter to override org-babel-clojure-backend > - Adds :args param (right now only used for clojure-cli) > > I have tested it with these minimal cases: > > #+begin_src clojure :backend clj-cli :args "-Sdeps '{:deps {inflections > {:mvn/version \"0.13.2\"}}}'" > (use 'inflections.core) > (plural "word") > #+end_src > > #+begin_src clojure :backend babashka :results output > (range 10) > #+end_src > > Please let me know what you think. Any advice is appreciated, since I > have never contributed before. Thank you.