bug: using remember can cause data corruption in other buffers

bug: using remember can cause data corruption in other buffers

[Samuel Wales]

Hi Carsten,

The following form in org-remember.el appears to set the global value.

    (setq auto-save-visited-file-name t)

This is the right thing for remember buffers, but it should be
buffer-local.  It could lead to data corruption in other buffers if
you make changes that you don't intend to be permanent.

I think that

  (set (make-variable-buffer-local ...) t)

would fix it.

This might or might not also fix a bug where emacs thinks that another
process is locking the file that is currently being edited.  I don't
know why.

Once this is fixed, I recommend that everybody who used git within the
last day or so, and I think set the remember directory, get the fixed
version and check the value of that variable.

Thanks.

-- 
Myalgic encephalomyelitis denialism is causing death (decades early;
Jason et al. 2006) and severe suffering (worse than nearly all other
diseases studied; e.g. Schweitzer et al. 1995) and grossly corrupting
science.  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

Re: bug: using remember can cause data corruption in other buffers

[Samuel Wales]

On Wed, Mar 25, 2009 at 20:13, Samuel Wales <samologist@gmail.com> wrote:
>  (set (make-variable-buffer-local ...) t)

That should be make-local-variable .

-- 
Myalgic encephalomyelitis denialism is causing death (decades early;
Jason et al. 2006) and severe suffering (worse than nearly all other
diseases studied; e.g. Schweitzer et al. 1995) and grossly corrupting
science.  http://www.meactionuk.org.uk/What_Is_ME_What_Is_CFS.htm

Re: bug: using remember can cause data corruption in other buffers

[Carsten Dominik]

On Mar 26, 2009, at 4:13 AM, Samuel Wales wrote:

> Hi Carsten,
>
> The following form in org-remember.el appears to set the global value.
>
>    (setq auto-save-visited-file-name t)
>
> This is the right thing for remember buffers, but it should be
> buffer-local.  It could lead to data corruption in other buffers if
> you make changes that you don't intend to be permanent.
>
> I think that
>
>  (set (make-variable-buffer-local ...) t)
>
> would fix it.

Applied, thanks.

>
> This might or might not also fix a bug where emacs thinks that another
> process is locking the file that is currently being edited.  I don't
> know why.
>
> Once this is fixed, I recommend that everybody who used git within the
> last day or so, and I think set the remember directory

Yes, this wil only have caused a problem for people who actually set  
the backup
directory.

Thank you.

- Carsten