patch to fix strange key binding bug and to notate compiler warnings

From: "Samuel Wales" <samologist@gmail.com>
To: emacs-orgmode@gnu.org
Subject: patch to fix strange key binding bug and to notate compiler warnings
Date: Sat, 6 Sep 2008 11:42:33 -0700	[thread overview]
Message-ID: <20524da70809061142s4f0a1003s2611a79431d162f1@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 140 bytes --]

The attached patch adds a variable to let you fix key bindings.  It
also provides comments for 2 places where there were compiler
warnings.

[-- Attachment #2: mydiffu --]
[-- Type: application/octet-stream, Size: 2109 bytes --]

--- org-orig.el	2008-09-06 10:37:32.000000000 -0700
+++ org-mypatch.el	2008-09-06 11:36:54.000000000 -0700
@@ -255,6 +255,19 @@
   :group 'org-startup
   :type 'boolean)
 
+(defcustom org-use-extra-keys nil
+  "Non-nil means use extra key sequence definitions for certain
+commands.  This happens automatically if you run XEmacs or if
+window-system is nil.  This variable lets you do the same
+manually.  You must set it before loading org.
+
+Example: on Carbon Emacs 22 running graphically, with an external
+keyboard on a Powerbook, the default way of setting M-left might
+not work for either Alt or ESC.  Setting this variable will make
+it work for ESC."
+  :group 'org-startup
+  :type 'boolean)
+
 (defcustom org-replace-disputed-keys nil
   "Non-nil means use alternative key bindings for some keys.
 Org-mode uses S-<cursor> keys for changing timestamps and priorities.
@@ -7036,6 +7049,7 @@
       (when (string-match "{{\\([^}]+\\)}}$" s)
 	(setq a (match-string 1 s) s (substring s 0 (match-beginning 0)))
 	(while (string-match "\\([a-zA-Z]+\\)=\"\\([^\"]*\\)\"" a start)
+          ;;are key and value dynamic variables here?
 	  (setq key (match-string 1 a) value (match-string 2 a)
 		start (match-end 0)
 		attr (plist-put attr (intern key) value))))
@@ -9470,6 +9484,7 @@
 		     `(,level-op level ,(string-to-number
 					 (match-string 4 term))))
 		    (prop-p
+                     ;;should time-p be let-bound here?
 		     (setq pn (match-string 5 term)
 			   po (match-string 6 term)
 			   pv (match-string 7 term)
@@ -12491,8 +12506,9 @@
 ;;  We only set them when really needed because otherwise the
 ;;  menus don't show the simple keys
 
-(when (or (featurep 'xemacs)   ;; because XEmacs supports multi-device stuff
-	  (not window-system))
+(when (or org-use-extra-keys
+          (featurep 'xemacs)    ; because XEmacs supports multi-device stuff
+          (not window-system))
   (org-defkey org-mode-map "\C-c\C-xc"    'org-table-copy-down)
   (org-defkey org-mode-map "\C-c\C-xM"    'org-insert-todo-heading)
   (org-defkey org-mode-map "\C-c\C-xm"    'org-meta-return)

[-- Attachment #3: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
