From: "Rudolf Adamkovič" <salutis@me.com>
To: emacs-orgmode@gnu.org
Cc: "Rudolf Adamkovič" <salutis@me.com>
Subject: [PATCH] Fix a possibly problematic string comparison
Date: Sun, 27 Aug 2023 23:43:20 +0200 [thread overview]
Message-ID: <20230827214320.46754-1-salutis@me.com> (raw)
* lisp/org-table.el (org-table-make-reference): Replace 'eq' with
'string-empty-p' to resolve "Warning: 'eq' called with literal string
that may never match" issued on every 'make' invocation.
---
lisp/org-table.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-table.el b/lisp/org-table.el
index f5a433c7d..b82749469 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -2864,7 +2864,7 @@ list, `literal' is for the format specifier L."
(if lispp
(if (eq lispp 'literal)
elements
- (if (and (eq elements "") (not keep-empty))
+ (if (and (string-empty-p elements) (not keep-empty))
""
(prin1-to-string
(if numbers (string-to-number elements) elements))))
--
2.41.0
next reply other threads:[~2023-08-27 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-27 21:43 Rudolf Adamkovič [this message]
2023-08-28 8:45 ` [PATCH] Fix a possibly problematic string comparison Ihor Radchenko
2023-08-29 0:02 ` Rudolf Adamkovič
2023-08-29 5:10 ` Ihor Radchenko
2023-08-29 23:56 ` Rudolf Adamkovič
2024-05-09 9:00 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230827214320.46754-1-salutis@me.com \
--to=salutis@me.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).