emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-lint does not finish on some org-mode buffer
@ 2015-08-09 18:46 Gregor Zattler
  2015-08-09 22:25 ` Nicolas Goaziou
  2015-11-10 15:59 ` Karl Voit
  0 siblings, 2 replies; 8+ messages in thread
From: Gregor Zattler @ 2015-08-09 18:46 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Dear org-mode developers,

I run org-lint on one of my org-mode buffers -- 13015 lines with
~2000 CLOCK: lines -- and it did not finish within 1 1/2 hours.

Is this a bug?  I did another run for a few minutes and profiled
this on.  Profiler reports are attached.

This is on

GNU Emacs 25.0.50.7 (i686-pc-linux-gnu, GTK+ Version 3.14.5) of
2015-07-29 on boo

and

Org-mode version 8.3.1 (release_8.3.1-16-g2156ab @
/home/grfz/src/org-mode/lisp/)


Ciao, Gregor
-- 
 -... --- .-. . -.. ..--.. ...-.-

[-- Attachment #2: cpu-profil-on-org-link.gz --]
[-- Type: application/gzip, Size: 3553 bytes --]

[-- Attachment #3: memory-profil-on-org-lint.gz --]
[-- Type: application/gzip, Size: 9718 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: org-lint does not finish on some org-mode buffer
  2015-08-09 18:46 org-lint does not finish on some org-mode buffer Gregor Zattler
@ 2015-08-09 22:25 ` Nicolas Goaziou
  2015-08-09 23:19   ` Gregor Zattler
  2015-11-10 15:59 ` Karl Voit
  1 sibling, 1 reply; 8+ messages in thread
From: Nicolas Goaziou @ 2015-08-09 22:25 UTC (permalink / raw)
  To: emacs-orgmode

Hello,

Gregor Zattler <telegraph@gmx.net> writes:

> I run org-lint on one of my org-mode buffers -- 13015 lines with
> ~2000 CLOCK: lines -- and it did not finish within 1 1/2 hours.
>
> Is this a bug?  I did another run for a few minutes and profiled
> this on.  Profiler reports are attached.

It looks like an infloop when trying to parse a link. Could you send the
file, or even bisect the file in order to find problematic link?

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: org-lint does not finish on some org-mode buffer
  2015-08-09 22:25 ` Nicolas Goaziou
@ 2015-08-09 23:19   ` Gregor Zattler
  2015-08-10  8:08     ` Nicolas Goaziou
  0 siblings, 1 reply; 8+ messages in thread
From: Gregor Zattler @ 2015-08-09 23:19 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

Hi Nicolas,
* Nicolas Goaziou <mail@nicolasgoaziou.fr> [10. Aug. 2015]:
> Gregor Zattler <telegraph@gmx.net> writes:
>> I run org-lint on one of my org-mode buffers -- 13015 lines with
>> ~2000 CLOCK: lines -- and it did not finish within 1 1/2 hours.
>>
>> Is this a bug?  I did another run for a few minutes and profiled
>> this on.  Profiler reports are attached.
> 
> It looks like an infloop when trying to parse a link. Could you send the
> file, or even bisect the file in order to find problematic link?

You are right.  I bisected the file.  There is a ’>’ missing.  At
least with my configuration the attached file ’bad.org’ freezes
Emacs with latest org-mode (but it is in most cases possible to
do a C-G):

emacs-snapshot -Q -L ~/src/org-mode/lisp/  -nw bad.org

I consider this a bug.


File ’good.org’ with closing ’>’ does not cause this problems.

Thanks for your help.




Ciao, Gregor
-- 
 -... --- .-. . -.. ..--.. ...-.-

[-- Attachment #2: good.org --]
[-- Type: text/plain, Size: 183 bytes --]

#-*- mode: Org; indent-tabs-mode: nil; coding: utf-8-unix;  -*-

               E-Mail: <mailto:ABCDEF.ABCDE@ABCDEF.de>
               http://www.ABCDEF.de
               ABCDEF GmbH

[-- Attachment #3: bad.org --]
[-- Type: text/plain, Size: 182 bytes --]

#-*- mode: Org; indent-tabs-mode: nil; coding: utf-8-unix;  -*-

               E-Mail: <mailto:ABCDEF.ABCDE@ABCDEF.de
               http://www.ABCDEF.de
               ABCDEF GmbH

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: org-lint does not finish on some org-mode buffer
  2015-08-09 23:19   ` Gregor Zattler
@ 2015-08-10  8:08     ` Nicolas Goaziou
  0 siblings, 0 replies; 8+ messages in thread
From: Nicolas Goaziou @ 2015-08-10  8:08 UTC (permalink / raw)
  To: emacs-orgmode

Gregor Zattler <telegraph@gmx.net> writes:

> You are right.  I bisected the file.  There is a ’>’ missing.  At
> least with my configuration the attached file ’bad.org’ freezes
> Emacs with latest org-mode (but it is in most cases possible to
> do a C-G):
>
> emacs-snapshot -Q -L ~/src/org-mode/lisp/  -nw bad.org
>
> I consider this a bug.

And a very bad one. This should be fixed. Thank you.

Regards,

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: org-lint does not finish on some org-mode buffer
  2015-08-09 18:46 org-lint does not finish on some org-mode buffer Gregor Zattler
  2015-08-09 22:25 ` Nicolas Goaziou
@ 2015-11-10 15:59 ` Karl Voit
  2015-11-10 22:52   ` Nicolas Goaziou
  1 sibling, 1 reply; 8+ messages in thread
From: Karl Voit @ 2015-11-10 15:59 UTC (permalink / raw)
  To: emacs-orgmode

* Gregor Zattler <telegraph@gmx.net> wrote:
>
> I run org-lint on one of my org-mode buffers -- 13015 lines with
> ~2000 CLOCK: lines -- and it did not finish within 1 1/2 hours.

Independent to your resolved issue: on my Org-mode files with 30,000
to 40,000 lines of Org-mode my computer took up to 12 hours to
finish org-lint.

Interesting fact: after finishing and saving the results, GNU/Emacs
runs into an endless-loop when I try to exit Emacs.

If this is of any interest, I can re-run org-lint over night and
post the stack trace of C-g.

-- 
mail|git|SVN|photos|postings|SMS|phonecalls|RSS|CSV|XML to Org-mode:
       > get Memacs from https://github.com/novoid/Memacs <

https://github.com/novoid/extract_pdf_annotations_to_orgmode + more on github

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: org-lint does not finish on some org-mode buffer
  2015-11-10 15:59 ` Karl Voit
@ 2015-11-10 22:52   ` Nicolas Goaziou
  2015-11-11  9:40     ` Karl Voit
  0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Goaziou @ 2015-11-10 22:52 UTC (permalink / raw)
  To: Karl Voit; +Cc: Karl Voit, emacs-orgmode

Hello,

Karl Voit <devnull@Karl-Voit.at> writes:

> Independent to your resolved issue: on my Org-mode files with 30,000
> to 40,000 lines of Org-mode my computer took up to 12 hours to
> finish org-lint.
>
> Interesting fact: after finishing and saving the results, GNU/Emacs
> runs into an endless-loop when I try to exit Emacs.
>
> If this is of any interest, I can re-run org-lint over night and
> post the stack trace of C-g.

It is. C-g with `toggle-debug-on-quit' would be interesting. Also, you
could bisect your document to check if is really coming from its sheer
size or from particular structure in it.

Thank you.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: org-lint does not finish on some org-mode buffer
  2015-11-10 22:52   ` Nicolas Goaziou
@ 2015-11-11  9:40     ` Karl Voit
  2015-11-11 20:45       ` Nicolas Goaziou
  0 siblings, 1 reply; 8+ messages in thread
From: Karl Voit @ 2015-11-11  9:40 UTC (permalink / raw)
  To: emacs-orgmode

* Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,

Hi Nicolas!

> Karl Voit <devnull@Karl-Voit.at> writes:
>
> It is. C-g with `toggle-debug-on-quit' would be interesting. Also, you
> could bisect your document to check if is really coming from its sheer
> size or from particular structure in it.

I have several Org-mode related issues so `toggle-debug-on-quit' is
always active at my side :-)

I've done org-lint on [1] which was finished quite fast - so it's not
an issue with my huge files only: I had to kill -9 Emacs to quit.

I was using Emacs 24.4.1  (x86_64-pc-linux-gnu, GTK+ Version 3.14.5)
from Debian stable (Jessie).

First, I tried to start Emacs without my personal configuration:

Emacs was started (in command line version without XOrg) via:
#+BEGIN_SRC sh
emacs --no-init-file --no-site-file
#+END_SRC

In *scratch* I executed following lines to switch from default
Org-mode to my local git version:
#+BEGIN_SRC elisp
  (add-to-list 'load-path "~/.emacs.d/contrib/org-mode/lisp")
  (add-to-list 'load-path "~/.emacs.d/contrib/org-mode/contrib/lisp" t)
  (require 'org-lint)
#+END_SRC

After opening [1] I got "Variable binding depth exceeds max-specpdl-size".
No idea, what I am missing to test it with --no-init-file. Maybe you
can tell me.


With my config from [2] (with XOrg) and Org-mode from git[3] I got
an error message I was not able to post it here because of special
characters: [4]

[1] https://github.com/novoid/lazyblorg/blob/master/dev/lazyblorg.org

[2] https://github.com/novoid/dot-emacs

[3] c032c48e8407f1a888396d2cb5e5d1b12099fe30

[4] http://Karl-Voit.at/temp/2015-11-11-org-lint-error.txt (online
    for a couple of days)

-- 
mail|git|SVN|photos|postings|SMS|phonecalls|RSS|CSV|XML to Org-mode:
       > get Memacs from https://github.com/novoid/Memacs <

https://github.com/novoid/extract_pdf_annotations_to_orgmode + more on github

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: org-lint does not finish on some org-mode buffer
  2015-11-11  9:40     ` Karl Voit
@ 2015-11-11 20:45       ` Nicolas Goaziou
  0 siblings, 0 replies; 8+ messages in thread
From: Nicolas Goaziou @ 2015-11-11 20:45 UTC (permalink / raw)
  To: Karl Voit; +Cc: Karl Voit, emacs-orgmode

Karl Voit <devnull@Karl-Voit.at> writes:

> I've done org-lint on [1] which was finished quite fast - so it's not
> an issue with my huge files only: I had to kill -9 Emacs to quit.

You can select individual checkers or categories for org-lint (see
docstring). It may be interesting to find which checker it faulty.
I guess it is `invalid-id-link'.

Also, could you provide the backtrace with an un-compiled Org? It is
much more informative.


Regards,

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-11-11 20:43 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-09 18:46 org-lint does not finish on some org-mode buffer Gregor Zattler
2015-08-09 22:25 ` Nicolas Goaziou
2015-08-09 23:19   ` Gregor Zattler
2015-08-10  8:08     ` Nicolas Goaziou
2015-11-10 15:59 ` Karl Voit
2015-11-10 22:52   ` Nicolas Goaziou
2015-11-11  9:40     ` Karl Voit
2015-11-11 20:45       ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).