From: Carsten Dominik <cdominik@newartisans.com>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Add source subtree which will be refiled
Date: Fri, 14 Oct 2011 11:20:54 +0200 (CEST) [thread overview]
Message-ID: <20111014092054.3FB29621EB2@carsten-dominiks-macbook-pro.local> (raw)
In-Reply-To: 80lisogetx.fsf@somewhere.org
Patch 989 (http://patchwork.newartisans.com/patch/989/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C80lisogetx.fsf%40somewhere.org%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] Add source subtree which will be refiled
> Date: Fri, 14 Oct 2011 13:25:14 -0000
> From: =?utf-8?q?S=C3=83=C2=A9bastien_Vauban_=3Cwxhgmqzgwmuf=40spammotel=2Ec?=
> =?utf-8?b?b20+?=
> X-Patchwork-Id: 989
> Message-Id: <80lisogetx.fsf@somewhere.org>
> To: emacs-orgmode@gnu.org
>
> Hi Carsten,
>
> > "Sebastien Vauban" wrote:
> >> Carsten Dominik wrote:
> >>>> I found it difficult, sometimes, to remember which subtree we're gonna
> >>>> refile. When TAB'ing for multiple targets, you loose your source buffer,
> >>>> and can easily forget which exact subtree you had selected.
> >>>>
> >>>> Here a patch to add the name of the subtree we're operating on.
> >>>
> >>> can you please resubmit a modified patch using either (org-get-heading t t)
> >>> or (nth 4 (org-heading-components))
> >>
> >> Thanks for looking at it.
> >>
> >> I'll do!
> >
> > Here it is: a modified version which only uses the text of the entry when
> > asking where to refile some headline.
>
> Please disregard http://patchwork.newartisans.com/patch/987/ as it contained 2
> typos.
>
> This one is correct and can be applied straight away.
>
> Best regards,
> Seb
>
>
> >From e86292614425dd385af7857384853e8e6245462f Mon Sep 17 00:00:00 2001
> From: Sebastien Vauban <sva@mygooglest.com>
> Date: Fri, 14 Oct 2011 09:18:55 +0200
> Subject: [PATCH] Use the text of the heading when refiling.
>
> ---
> lisp/org.el | 22 ++++++++++++++--------
> 1 files changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index b26e1a3..66c2507 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10481,14 +10481,20 @@ prefix argument (`C-u C-u C-u C-c C-w')."
> (marker-position org-clock-hd-marker)))
> (setq goto nil)))
> (setq it (or rfloc
> - (save-excursion
> - (unless goto (org-back-to-heading t))
> - (org-refile-get-location
> - (cond (goto "Goto")
> - (regionp "Refile region to")
> - (t "Refile subtree to")) default-buffer
> - org-refile-allow-creating-parent-nodes
> - goto)))))
> + (let (heading-text)
> + (save-excursion
> + (unless goto
> + (org-back-to-heading t)
> + (setq heading-text
> + (nth 4 (org-heading-components))))
> + (org-refile-get-location
> + (cond (goto "Goto")
> + (regionp "Refile region to")
> + (t (concat "Refile subtree \""
> + heading-text "\" to")))
> + default-buffer
> + org-refile-allow-creating-parent-nodes
> + goto))))))
> (setq file (nth 1 it)
> re (nth 2 it)
> pos (nth 3 it))
> --
> 1.7.5.1
>
>
next prev parent reply other threads:[~2011-10-18 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 9:19 [patch] Add source subtree which will be refiled Sebastien Vauban
2011-10-09 11:29 ` Carsten Dominik
2011-10-09 18:35 ` Sebastien Vauban
2011-10-12 5:13 ` Sebastien Vauban
2011-10-14 8:25 ` Sebastien Vauban
2011-10-14 9:20 ` Carsten Dominik [this message]
2011-10-14 9:21 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014092054.3FB29621EB2@carsten-dominiks-macbook-pro.local \
--to=cdominik@newartisans.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).