[PATCH] Fix an error in org-taskjuggler-get-unique-id

[PATCH] Fix an error in org-taskjuggler-get-unique-id

[Christian Egli]

Don't try to pop from an empty list and downcase the result
---
 lisp/org-taskjuggler.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/org-taskjuggler.el b/lisp/org-taskjuggler.el
index 23f4b62..6367b7a 100644
--- a/lisp/org-taskjuggler.el
+++ b/lisp/org-taskjuggler.el
@@ -503,7 +503,7 @@ finally add more underscore characters (\"_\")."
 	 (parts (split-string headline))
 	 (id (org-taskjuggler-clean-id (downcase (pop parts)))))
     ; try to add more parts of the headline to make it unique
-    (while (member id unique-ids)
+    (while (and (member id unique-ids) (car parts))
       (setq id (concat id "_" (org-taskjuggler-clean-id (downcase (pop parts))))))
     ; if its still not unique add "_"
     (while (member id unique-ids)
-- 
1.7.0.4

[Accepted] Fix an error in org-taskjuggler-get-unique-id

[Bastien Guerry]

Patch 326 (http://patchwork.newartisans.com/patch/326/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C871v7modmr.fsf%40saadawi.sbszh.ch%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Fix an error in org-taskjuggler-get-unique-id
> Date: Tue, 19 Oct 2010 12:17:16 -0000
> From: Christian Egli <christian.egli@alumni.ethz.ch>
> X-Patchwork-Id: 326
> Message-Id: <871v7modmr.fsf@saadawi.sbszh.ch>
> To: emacs-orgmode@gnu.org
> 
> Don't try to pop from an empty list and downcase the result
> 
> ---
> lisp/org-taskjuggler.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-taskjuggler.el b/lisp/org-taskjuggler.el
> index 23f4b62..6367b7a 100644
> --- a/lisp/org-taskjuggler.el
> +++ b/lisp/org-taskjuggler.el
> @@ -503,7 +503,7 @@ finally add more underscore characters (\"_\")."
>  	 (parts (split-string headline))
>  	 (id (org-taskjuggler-clean-id (downcase (pop parts)))))
>      ; try to add more parts of the headline to make it unique
> -    (while (member id unique-ids)
> +    (while (and (member id unique-ids) (car parts))
>        (setq id (concat id "_" (org-taskjuggler-clean-id (downcase (pop parts))))))
>      ; if its still not unique add "_"
>      (while (member id unique-ids)
>