From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien Guerry <bzg@altern.org>
Subject: [Accepted] Fix an error in org-taskjuggler-get-unique-id
Date: Wed, 20 Oct 2010 14:07:24 +0200 (CEST)
Message-ID: <20101020120724.0BAB4446B0@myhost.localdomain>
References: <871v7modmr.fsf@saadawi.sbszh.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=46436 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P8XS6-0004e6-U8
	for emacs-orgmode@gnu.org; Wed, 20 Oct 2010 08:07:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1P8XS4-0003J2-DK
	for emacs-orgmode@gnu.org; Wed, 20 Oct 2010 08:07:30 -0400
Received: from mail-wy0-f169.google.com ([74.125.82.169]:54553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1P8XS4-0003Iw-7e
	for emacs-orgmode@gnu.org; Wed, 20 Oct 2010 08:07:28 -0400
Received: by wyf28 with SMTP id 28so3863345wyf.0
	for <emacs-orgmode@gnu.org>; Wed, 20 Oct 2010 05:07:27 -0700 (PDT)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Patch 326 (http://patchwork.newartisans.com/patch/326/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C871v7modmr.fsf%40saadawi.sbszh.ch%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Fix an error in org-taskjuggler-get-unique-id
> Date: Tue, 19 Oct 2010 12:17:16 -0000
> From: Christian Egli <christian.egli@alumni.ethz.ch>
> X-Patchwork-Id: 326
> Message-Id: <871v7modmr.fsf@saadawi.sbszh.ch>
> To: emacs-orgmode@gnu.org
> 
> Don't try to pop from an empty list and downcase the result
> 
> ---
> lisp/org-taskjuggler.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-taskjuggler.el b/lisp/org-taskjuggler.el
> index 23f4b62..6367b7a 100644
> --- a/lisp/org-taskjuggler.el
> +++ b/lisp/org-taskjuggler.el
> @@ -503,7 +503,7 @@ finally add more underscore characters (\"_\")."
>  	 (parts (split-string headline))
>  	 (id (org-taskjuggler-clean-id (downcase (pop parts)))))
>      ; try to add more parts of the headline to make it unique
> -    (while (member id unique-ids)
> +    (while (and (member id unique-ids) (car parts))
>        (setq id (concat id "_" (org-taskjuggler-clean-id (downcase (pop parts))))))
>      ; if its still not unique add "_"
>      (while (member id unique-ids)
>