emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien Guerry <bzg@altern.org>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Fix an error in org-taskjuggler-get-unique-id
Date: Wed, 20 Oct 2010 14:07:24 +0200 (CEST)	[thread overview]
Message-ID: <20101020120724.0BAB4446B0@myhost.localdomain> (raw)
In-Reply-To: 871v7modmr.fsf@saadawi.sbszh.ch

Patch 326 (http://patchwork.newartisans.com/patch/326/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C871v7modmr.fsf%40saadawi.sbszh.ch%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Fix an error in org-taskjuggler-get-unique-id
> Date: Tue, 19 Oct 2010 12:17:16 -0000
> From: Christian Egli <christian.egli@alumni.ethz.ch>
> X-Patchwork-Id: 326
> Message-Id: <871v7modmr.fsf@saadawi.sbszh.ch>
> To: emacs-orgmode@gnu.org
> 
> Don't try to pop from an empty list and downcase the result
> 
> ---
> lisp/org-taskjuggler.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-taskjuggler.el b/lisp/org-taskjuggler.el
> index 23f4b62..6367b7a 100644
> --- a/lisp/org-taskjuggler.el
> +++ b/lisp/org-taskjuggler.el
> @@ -503,7 +503,7 @@ finally add more underscore characters (\"_\")."
>  	 (parts (split-string headline))
>  	 (id (org-taskjuggler-clean-id (downcase (pop parts)))))
>      ; try to add more parts of the headline to make it unique
> -    (while (member id unique-ids)
> +    (while (and (member id unique-ids) (car parts))
>        (setq id (concat id "_" (org-taskjuggler-clean-id (downcase (pop parts))))))
>      ; if its still not unique add "_"
>      (while (member id unique-ids)
> 

      reply	other threads:[~2010-10-20 12:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  7:17 [PATCH] Fix an error in org-taskjuggler-get-unique-id Christian Egli
2010-10-20 12:07 ` Bastien Guerry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101020120724.0BAB4446B0@myhost.localdomain \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).