[PATCH] tag input separators

[PATCH] tag input separators

[Richard Riley]

I dont know if it would be generally useful, but a tiny little tweak to
tag editing in order to allow "," as a seperator when typing in tags via
C-c C-q TAB "free entry" interface. "," is certainly easier for me to
use but I dont know about the ramifications of it as a legal character
in a tag name.


--8<---------------cut here---------------start------------->8---
	Modified lisp/org.el
diff --git a/lisp/org.el b/lisp/org.el
index 3f24ee8..fa3d364 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12792,6 +12792,8 @@ With prefix ARG, realign all tags in headings in the current buffer."
 	  ;; No boolean logic, just a list
 	  (setq tags (replace-match ":" t t tags))))
 
+      (setq tags (replace-regexp-in-string "[ ,]" ":" tags))
+
       (if org-tags-sort-function
       	  (setq tags (mapconcat 'identity
       				(sort (org-split-string tags (org-re "[^[:alnum:]_@#%]+"))
--8<---------------cut here---------------end--------------->8---

I replaced space too but that isnt currently allowed anyway.

regards

r.

Re: [PATCH] tag input separators

[Carsten Dominik]

On Oct 4, 2010, at 11:44 AM, Richard Riley wrote:

>
> I dont know if it would be generally useful, but a tiny little tweak  
> to
> tag editing in order to allow "," as a seperator when typing in tags  
> via
> C-c C-q TAB "free entry" interface. "," is certainly easier for me to
> use but I dont know about the ramifications of it as a legal character
> in a tag name.

Sure, why not, this is not a problem.  I have applied this patch,
with a small extension that should also make it work in other
tag completion situations.

If you want to do me a favor, please identify one or two places in
the manual where this should be mentioned and make me a patch
for that file?

Cheers

- Carsten

>
>
> --8<---------------cut here---------------start------------->8---
> 	Modified lisp/org.el
> diff --git a/lisp/org.el b/lisp/org.el
> index 3f24ee8..fa3d364 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -12792,6 +12792,8 @@ With prefix ARG, realign all tags in  
> headings in the current buffer."
> 	  ;; No boolean logic, just a list
> 	  (setq tags (replace-match ":" t t tags))))
>
> +      (setq tags (replace-regexp-in-string "[ ,]" ":" tags))
> +
>       (if org-tags-sort-function
>       	  (setq tags (mapconcat 'identity
>       				(sort (org-split-string tags (org-re "[^[:alnum:]_@#%]+"))
> --8<---------------cut here---------------end--------------->8---
>
> I replaced space too but that isnt currently allowed anyway.
>
> regards
>
> r.
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

[Accepted] tag input separators

[Carsten Dominik]

Patch 297 (http://patchwork.newartisans.com/patch/297/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3Ci8c7me%24g3n%241%40dough.gmane.org%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] tag input separators
> Date: Mon, 04 Oct 2010 14:44:44 -0000
> From: Richard Riley <rileyrg@googlemail.com>
> X-Patchwork-Id: 297
> Message-Id: <i8c7me$g3n$1@dough.gmane.org>
> To: emacs-orgmode@gnu.org
> 
> I dont know if it would be generally useful, but a tiny little tweak to
> tag editing in order to allow "," as a seperator when typing in tags via
> C-c C-q TAB "free entry" interface. "," is certainly easier for me to
> use but I dont know about the ramifications of it as a legal character
> in a tag name.
> 
> 
> --8<---------------cut here---------------start------------->8---
> 	Modified lisp/org.el
> --8<---------------cut here---------------end--------------->8---
> 
> I replaced space too but that isnt currently allowed anyway.
> 
> regards
> 
> r.
> 
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index 3f24ee8..fa3d364 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -12792,6 +12792,8 @@ With prefix ARG, realign all tags in headings in the current buffer."
>  	  ;; No boolean logic, just a list
>  	  (setq tags (replace-match ":" t t tags))))
>  
> +      (setq tags (replace-regexp-in-string "[ ,]" ":" tags))
> +
>        (if org-tags-sort-function
>        	  (setq tags (mapconcat 'identity
>        				(sort (org-split-string tags (org-re "[^[:alnum:]_@#%]+"))
> 

Re: [PATCH] tag input separators

[Bastien]

Hi,

Carsten Dominik <carsten.dominik@gmail.com> writes:

> On Oct 4, 2010, at 11:44 AM, Richard Riley wrote:
>
>>
>> I dont know if it would be generally useful, but a tiny little tweak to
>> tag editing in order to allow "," as a seperator when typing in tags via
>> C-c C-q TAB "free entry" interface. "," is certainly easier for me to
>> use but I dont know about the ramifications of it as a legal character
>> in a tag name.
>
> Sure, why not, this is not a problem.  I have applied this patch,
> with a small extension that should also make it work in other
> tag completion situations.

Note that, in this case, tag completion works for the first tag but not
for the others.

> If you want to do me a favor, please identify one or two places in
> the manual where this should be mentioned and make me a patch
> for that file?

I have applied this patch to the documentation:

diff --git a/doc/org.texi b/doc/org.texi
index 6d39a61..89baba6 100644
--- a/doc/org.texi
+++ b/doc/org.texi
@@ -4504,6 +4504,8 @@ exclusive tags will turn off any other tags from that group.
 @item @key{TAB}
 Enter a tag in the minibuffer, even if the tag is not in the predefined
 list.  You will be able to complete on all tags present in the buffer.
+You can also add several tags: just separate them with a comma.
+
 @kindex @key{SPC}
 @item @key{SPC}
 Clear all tags for this line.

-- 
 Bastien