emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Use `C-c C-x _' for interactively calling `org-timer-stop'
@ 2010-09-02 20:19 Bastien
  2010-09-02 21:08 ` Nicolas Goaziou
  2010-09-05 20:28 ` [Accepted] " Bastien Guerry
  0 siblings, 2 replies; 4+ messages in thread
From: Bastien @ 2010-09-02 20:19 UTC (permalink / raw)
  To: emacs-orgmode

Unless I missed something, `org-timer-stop' has no keybinding yet.
I propose to use `C-c C-x _'.

Is that okay for everyone?

diff --git a/lisp/org.el b/lisp/org.el
index fc44fc7..01da980 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -16383,6 +16383,7 @@ BEG and END default to the buffer boundaries."
 (org-defkey org-mode-map "\C-c\C-x."    'org-timer)
 (org-defkey org-mode-map "\C-c\C-x-"    'org-timer-item)
 (org-defkey org-mode-map "\C-c\C-x0"    'org-timer-start)
+(org-defkey org-mode-map "\C-c\C-x_"    'org-timer-stop)
 (org-defkey org-mode-map "\C-c\C-x,"    'org-timer-pause-or-continue)
 
 (define-key org-mode-map "\C-c\C-x\C-c" 'org-columns)

-- 
 Bastien

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: Use `C-c C-x _' for interactively calling `org-timer-stop'
  2010-09-02 20:19 Use `C-c C-x _' for interactively calling `org-timer-stop' Bastien
@ 2010-09-02 21:08 ` Nicolas Goaziou
  2010-09-02 21:36   ` Bastien
  2010-09-05 20:28 ` [Accepted] " Bastien Guerry
  1 sibling, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2010-09-02 21:08 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

Hello,
>>>>> Bastien  writes:

> Unless I missed something, `org-timer-stop' has no keybinding yet. I
> propose to use `C-c C-x _'.

Isn't it C-u C-c C-x , ?

Regards,

-- Nicolas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Use `C-c C-x _' for interactively calling `org-timer-stop'
  2010-09-02 21:08 ` Nicolas Goaziou
@ 2010-09-02 21:36   ` Bastien
  0 siblings, 0 replies; 4+ messages in thread
From: Bastien @ 2010-09-02 21:36 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

Nicolas Goaziou <n.goaziou@gmail.com> writes:

>> Unless I missed something, `org-timer-stop' has no keybinding yet. I
>> propose to use `C-c C-x _'.
>
> Isn't it C-u C-c C-x , ?

Mh..  yes, stop is kind of a "pause" variant.   

But I don't find thisto be very straightforward, and `org-timer-stop' is
already a command -- I thought it would make sense to have a key for it.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Accepted] Use `C-c C-x _' for interactively calling `org-timer-stop'
  2010-09-02 20:19 Use `C-c C-x _' for interactively calling `org-timer-stop' Bastien
  2010-09-02 21:08 ` Nicolas Goaziou
@ 2010-09-05 20:28 ` Bastien Guerry
  1 sibling, 0 replies; 4+ messages in thread
From: Bastien Guerry @ 2010-09-05 20:28 UTC (permalink / raw)
  To: emacs-orgmode

Patch 255 (http://patchwork.newartisans.com/patch/255/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C8762yn6gq0.fsf%40gnu.org%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Use `C-c C-x _' for interactively calling `org-timer-stop'
> Date: Fri, 03 Sep 2010 01:19:35 -0000
> From: Bastien <bastien.guerry@wikimedia.fr>
> X-Patchwork-Id: 255
> Message-Id: <8762yn6gq0.fsf@gnu.org>
> To: emacs-orgmode@gnu.org
> 
> Unless I missed something, `org-timer-stop' has no keybinding yet.
> I propose to use `C-c C-x _'.
> 
> Is that okay for everyone?
> 
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index fc44fc7..01da980 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -16383,6 +16383,7 @@ BEG and END default to the buffer boundaries."
>  (org-defkey org-mode-map "\C-c\C-x."    'org-timer)
>  (org-defkey org-mode-map "\C-c\C-x-"    'org-timer-item)
>  (org-defkey org-mode-map "\C-c\C-x0"    'org-timer-start)
> +(org-defkey org-mode-map "\C-c\C-x_"    'org-timer-stop)
>  (org-defkey org-mode-map "\C-c\C-x,"    'org-timer-pause-or-continue)
>  
>  (define-key org-mode-map "\C-c\C-x\C-c" 'org-columns)
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-09-05 20:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-02 20:19 Use `C-c C-x _' for interactively calling `org-timer-stop' Bastien
2010-09-02 21:08 ` Nicolas Goaziou
2010-09-02 21:36   ` Bastien
2010-09-05 20:28 ` [Accepted] " Bastien Guerry

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).