From mboxrd@z Thu Jan  1 00:00:00 1970
From: Friedrich Delgado Friedrichs <friedel@nomaden.org>
Subject: Re: org-infojs-handle-options fails when :infojs-opt is not  in
 exp-list
Date: Thu, 8 Jan 2009 15:12:20 +0100
Message-ID: <20090108141220.GA5649@taupan.ath.cx>
References: <20081223104736.GA25075@taupan.ath.cx>
	<20081223105631.GA25285@taupan.ath.cx>
	<20081223111440.GA25702@taupan.ath.cx>
Reply-To: friedel@nomaden.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LKvcb-00043M-PZ
	for emacs-orgmode@gnu.org; Thu, 08 Jan 2009 09:12:29 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LKvcZ-00042S-UA
	for emacs-orgmode@gnu.org; Thu, 08 Jan 2009 09:12:29 -0500
Received: from [199.232.76.173] (port=55317 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LKvcZ-00042G-H6
	for emacs-orgmode@gnu.org; Thu, 08 Jan 2009 09:12:27 -0500
Received: from dudelab.org ([212.12.33.202]:11227 helo=mail.dudelab.org)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <friedel@nomaden.org>) id 1LKvcZ-0004GM-6H
	for emacs-orgmode@gnu.org; Thu, 08 Jan 2009 09:12:27 -0500
Received: from abrasax.taupan.ath.cx (p5B10C72F.dip.t-dialin.net
	[91.16.199.47])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "Friedrich Delgado Friedrichs",
	Issuer "User CA" (verified OK))
	by mail.dudelab.org (Postfix) with ESMTP id 5A65C228148
	for <emacs-orgmode@gnu.org>; Thu,  8 Jan 2009 15:10:59 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20081223111440.GA25702@taupan.ath.cx>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Hi.

A while ago I had this problem:
org-infojs-handle-options: Wrong type argument: stringp, nil

I wonder if my patch ever reached the mailing list, or if it
was overlooked because it was too close to christmas:

Friedrich Delgado Friedrichs schrieb:
> >From 0fef25f56c837ae9f434449c6f30268e0474f7ab Mon Sep 17 00:00:00 2001
> From: Friedrich Delgado Friedrichs <delgado@dfn-cert.de>
> Date: Tue, 23 Dec 2008 12:10:42 +0100
> Subject: [PATCH] fix string-match against nil when no in-file options are set for jsinfo
> 
> ---
>  lisp/org-jsinfo.el |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-jsinfo.el b/lisp/org-jsinfo.el
> index 8f2d7e8..19faa9e 100644
> --- a/lisp/org-jsinfo.el
> +++ b/lisp/org-jsinfo.el
> @@ -140,7 +140,8 @@ Option settings will replace the %MANAGER-OPTIONS cookie."
>              default (cdr (assoc opt org-infojs-options)))
>        (and (symbolp default) (not (memq default '(t nil)))
>             (setq default (plist-get exp-plist default)))
> -      (if (string-match (format " %s:\\(\\S-+\\)" opt) v)
> +      (if (and v
> +               (string-match (format " %s:\\(\\S-+\\)" opt) v))
>            (setq val (match-string 1 v))
>          (setq val default))
>        (cond
> -- 
> 1.6.0.2.526.g5c283.dirty
---Zitatende---

-- 
        Friedrich Delgado Friedrichs <friedel@nomaden.org>
Laziness led to the invention of the most useful tools.