Re: Bug? Installing from git master

[Adam Spiers <orgmode@adamspiers.org>]

On Sat, Mar 01, 2008 at 04:35:14AM +0530, Manish wrote:
> On Sat, Mar 1, 2008 at 4:19 AM, Bastien <bzg@altern.org> wrote:
> > Manish <mailtomanish.sharma@gmail.com> writes:
> >
> >  > On Sat, Mar 1, 2008 at 3:39 AM, Bastien <bzg@altern.org> wrote:
> >  >> Manish <mailtomanish.sharma@gmail.com> writes:
> >  >>
> >  >>  > On Sat, Mar 1, 2008 at 3:04 AM, Carsten Dominik <dominik@science.uva.nl> wrote:
> >  >>  >
> >  >>
> >  >> > `make' now completes.  Though it still produces following warnings:
> >  >>
> >  >>  Fixed, thanks!
> >  >
> >  > Only following warnings are left now.
> >  >
> >  >   ,----
> >  >   | In end of data:
> >  >   | org-irc.el:231:1:Warning: the following functions might not be defined at
> >  >   |     runtime: find-if, find
> >  >   | org-irc.el:231:1:Warning: the function `erc-current-logfile' is not known to
> >  >   |     be defined.
> >  >   | Wrote /home/zms/elisp/org-mode/org-irc.elc
> >  >   `----
> >
> >  Argh. Fixed.
> >
> >  Is _everyone_ pulling from git in this room??

:-)

> I do.

Me too.

> `make' completes cleanly now.  Thanks.

... but only if you have erc installed (it's shipped with emacs 22 but
not emacs 21):

  $ make
  emacs -batch -q -eval "(progn (add-to-list (quote load-path) \".\") (add-to-list (quote load-path) \"/home/aspiers/lib/emacs/GNU_Emacs/21.3/gnu/linux/pre\"))" -f batch-byte-compile org-mouse.el
  Loading /usr/lib/emacs/21.3/i586-suse-linux/fns-21.3.1.el (source)...
  While compiling toplevel forms in file
  /home/aspiers/lib/emacs/major-modes/org-mode.git/org-mouse.el:
    !! File error (("Cannot open load file" "erc"))
  Done
  make: *** [org-mouse.elc] Error 1

This is because org-default-extensions defaults to (org-irc):

  emacs -batch -q -eval "(progn (setq debug-on-error t) (add-to-list (quote load-path) \".\") (add-to-list (quote load-path) \"/usr/local/share/emacs/site-lisp\") (require 'org))"
  Loading /usr/lib/emacs/21.3/i586-suse-linux/fns-21.3.1.el (source)...
  Debugger entered--Lisp error: (file-error "Cannot open load file" "erc")
    require(erc)
    eval-buffer(#<buffer  *load*> nil "org-irc" nil t)
    load-with-code-conversion("/home/aspiers/lib/emacs/major-modes/org-mode.git/org-irc.el" "org-irc" nil t)
    require(org-irc)
    mapc(require (org-irc))
    org-load-default-extensions()
    run-hooks(org-load-hook)
    byte-code("��!���!�" [provide org run-hooks org-load-hook] 2)
    require(org)
    (progn (setq debug-on-error t) (add-to-list (quote load-path) ".") (add-to-list (quote load-path) "/usr/local/share/emacs/site-lisp") (require (quote org)))
    eval((progn (setq debug-on-error t) (add-to-list (quote load-path) ".") (add-to-list (quote load-path) "/usr/local/share/emacs/site-lisp") (require (quote org))))
    command-line-1(("-eval" "(progn (setq debug-on-error t) (add-to-list (quote load-path) \".\") (add-to-list (quote load-path) \"/usr/local/share/emacs/site-lisp\") (require 'org))"))
    command-line()
    normal-top-level()

So it would be nice if it didn't default to (org-irc) for older emacsen.