From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Trent Buck" Subject: Re: require-final-newline Date: Thu, 24 May 2007 01:20:20 +1000 Message-ID: <20070523152020.GA13939@baal.lan> References: <20070521020326.GA14277@baal.lan> <31008adb289123cb43d3677063adaa58@science.uva.nl> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0193113006==" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HqsdZ-0004dA-8q for emacs-orgmode@gnu.org; Wed, 23 May 2007 11:20:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HqsdX-0004cL-E5 for emacs-orgmode@gnu.org; Wed, 23 May 2007 11:20:28 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HqsdX-0004cG-3i for emacs-orgmode@gnu.org; Wed, 23 May 2007 11:20:27 -0400 Received: from omta04sl.mx.bigpond.com ([144.140.93.156]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HqsdW-00055i-5T for emacs-orgmode@gnu.org; Wed, 23 May 2007 11:20:26 -0400 In-Reply-To: <31008adb289123cb43d3677063adaa58@science.uva.nl> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org --===============0193113006== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 23, 2007 at 04:15:41PM +0200, Carsten Dominik wrote: > To be honest, I am not sure that this is the right solution. For some=20 > operations in org-mode, like structure editing, that final newline is=20 > good to have. Also, this issue with the final newline is depending on=20 > personal preferences. >=20 > I tend to believe that the better solution is to fix outlining, so that= =20 > it will never hide empty lines at the end of the buffer. Hope you can=20 > agree if I implement that latter solution. Certainly. Now you point it out, I agree that is the "more correct" change to make. > On May 21, 2007, at 4:03, Trent Buck wrote: >=20 > >[Please CC replies; I'm not subscribed to this list.] > > > >I have the following in my .emacs: > > > > | ;;; If the last line is an item and you have a final newline, > > | ;;; collapsing item bodies will result in > > | ;;; > > | ;;; ** eat marshmallows... > > | ;;; > > | ;;; where the ellipsis is simply eliding the final newline. This > > | ;;; annoys me. Rather than fix org mode, I've opted to simply > > | ;;; disable implicit adding of a final newline for this mode. > > | (add-hook 'org-mode-hook > > | (lambda () > > | (set (make-local-variable 'require-final-newline) nil))) > > > >It would be better if org mode did this automatically. There is > >a facility specifically for this: > > > > | mode-require-final-newline is a variable defined in `files.el'. > > | > > | Documentation: > > | Whether to add a newline at end of file, in certain major modes. > > | Those modes set `require-final-newline' to this value when you=20 > >enable them. > > | They do so because they are often used for files that are supposed > > | to end in newlines, and the question is how to arrange that. > > | > > | A value of t means do this only when the file is about to be saved. > > | A value of `visit' means do this right after the file is visited. > > | A value of `visit-save' means do it at both of those times. > > | Any other non-nil value means ask user whether to add a newline,=20 > >when saving. > > | > > | nil means do not add newlines. That is a risky choice in this=20 > >variable > > | since this value is used for modes for files that ought to have=20 > >final newlines. > > | So if you set this to nil, you must explicitly check and add > > | a final newline, whenever you save a file that really needs one. > > > >I posit that org-mode should set this variable to nil. --=20 Trent Buck --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGVFu0Lpef9iTtxAYRAltEAJ9nq6gw2nddeymqrJLRgTYp9qKKcQCgjdib 3aoid1BeDngPyhTtBTlcTbE= =Vr6G -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s-- --===============0193113006== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============0193113006==--