From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2IkzC6eK515zTAAA0tVLHw (envelope-from ) for ; Mon, 15 Jun 2020 14:50:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uFscB6eK516zWwAAB5/wlQ (envelope-from ) for ; Mon, 15 Jun 2020 14:50:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2A0FA94013C for ; Mon, 15 Jun 2020 14:50:14 +0000 (UTC) Received: from localhost ([::1]:60428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkqR9-00055j-43 for larch@yhetil.org; Mon, 15 Jun 2020 10:50:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkqQg-00055N-LC for emacs-orgmode@gnu.org; Mon, 15 Jun 2020 10:49:42 -0400 Received: from devianza.investici.org ([198.167.222.108]:28157) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkqQd-0001kf-Jw for emacs-orgmode@gnu.org; Mon, 15 Jun 2020 10:49:42 -0400 Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 6D7B1E0565; Mon, 15 Jun 2020 14:49:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anche.no; s=stigmate; t=1592232574; bh=9yFYk61ot3KZWgYd2AlT9q9teTrIccZMEeSPY7A0awY=; h=Subject:To:References:From:Date:In-Reply-To:From; b=PftIpA5g9Eq9emOpplwdBz2rHy/vdXbNK/FfWKjPwvOCcOyEXJAROY3Ocy3yej+xb L+yhRyrWYqUzMwrRNmx9GB91mGHQsbMMW8LA7n/sqE4V+Mgi9d6C+Q1gVhA+fk+Eh2 8/JqhZStR2zaJCB14t6O82sg4mgvcYMyVE8uqxIU= Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: mariotomo@inventati.org) by localhost (Postfix) with ESMTPSA id 81744E0568; Mon, 15 Jun 2020 14:49:33 +0000 (UTC) Subject: Re: [PATCH] may we focus on readability? To: emacs-orgmode@gnu.org References: <871rmhe93z.fsf@nicolasgoaziou.fr> From: Mario Frasca Message-ID: <1a4fa99e-26b3-db80-e292-1001d762f8d5@anche.no> Date: Mon, 15 Jun 2020 09:49:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <871rmhe93z.fsf@nicolasgoaziou.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=198.167.222.108; envelope-from=mario@anche.no; helo=devianza.investici.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/15 10:49:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=anche.no header.s=stigmate header.b=PftIpA5g; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.21 X-TUID: hqAnK7zF0s3v Hi Nicolas, I think that the hint on testing is very correct, I'm afraid I changed the semantics of one of the original tests, and I found that there's other cl functions other than just cl-some, also cl-every, cl-notevery, and cl-notany.  I'll have a closer look at this.  and write some tests before changing the code. I also looked for the strange idiom used here, and these two are the only two locations I found. how do I run tests from the command line (I'm using make test) but then limited to one lisp file?  or one specific test? ciao, Mario On 14/06/2020 14:32, Nicolas Goaziou wrote: > […] > Also, further nit: (not (cl-every ...)) will apply `not' only once. > > In any case, it would be better if refactoring happens while introducing > unit tests *hint*. > > Regards,