From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YICyCK1m1mGiNQEAgWs5BA (envelope-from ) for ; Thu, 06 Jan 2022 04:49:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aCY6Ba1m1mE35wAAauVa8A (envelope-from ) for ; Thu, 06 Jan 2022 04:49:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 963923C36C for ; Thu, 6 Jan 2022 04:49:00 +0100 (CET) Received: from localhost ([::1]:41996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5Jlr-0007Xb-2O for larch@yhetil.org; Wed, 05 Jan 2022 22:48:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Jkx-0007WC-8q for emacs-orgmode@gnu.org; Wed, 05 Jan 2022 22:48:03 -0500 Received: from sender4-op-o14.zoho.com ([136.143.188.14]:17444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Jku-0004WC-Qv for emacs-orgmode@gnu.org; Wed, 05 Jan 2022 22:48:02 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1641440875; cv=none; d=zohomail.com; s=zohoarc; b=CJx3Mbyp85QvRJJg8pz9d6xXo0nZoNwb4eXBwsfg77wcWAz34djpKsHOJ6qqKyRw0BfAB+GvHjrtpChHoftyqnZ9nnhfFtPMK+M29cyQEmg1LrEN9njHbYJu42GUkO4J+/EZR513004nbYhh4+vxyR8hyU9qVkUS6MjNo4YHPjA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641440875; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=lPzIO6pfWPvaf8KLJShZ+ySrVGe0yGSUphPCRV+rZ7Q=; b=ANm+0cmCl3kwoWvEwE0hOgzCo7NClH/KO52YTffq6ADGT8HQRoutrPFKxrd0aGVUs6Cto1whCCmJnGUYjElxQnsnG1aIKsDPHzBeWuTMv7vUnJUzrLW7kbKgCv1E7Q9aVDtSw3uQC1tFKV8jX6f1aOuwK3CvGonKMH87jpfGa+I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=excalamus.com; spf=pass smtp.mailfrom=matt@excalamus.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1641440875; s=zmail; d=excalamus.com; i=matt@excalamus.com; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=lPzIO6pfWPvaf8KLJShZ+ySrVGe0yGSUphPCRV+rZ7Q=; b=GQq+xy9HIohguy5Azta+P/Jl0Z64CBRcAQQrWdjuXHvC+dx0GlW6wucoXSI0syo0 Q8KnqyiK3Na15yHSjT7C65rZiR0OA/4jLCSCTE5uY3i2oXHOKkpPTrjUCXHa5x3wiCg JcMVL6YggcFtBGeoW+AoNcnSSqMJsaTEWKkv/Wsk= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1641440874028205.49539680343105; Wed, 5 Jan 2022 19:47:54 -0800 (PST) Date: Wed, 05 Jan 2022 22:47:53 -0500 From: Matt To: "Max Nikulin" Message-ID: <17e2d800e0e.cfffb732642942.2036522928042669584@excalamus.com> In-Reply-To: References: <17d48f09729.ddbece82213631.8340272801066201269@excalamus.com> <87pmqs58mx.fsf@gmail.com> <17d53474fd6.c0a62421660695.6561002670353136607@excalamus.com> <87lf13pcme.fsf@gmail.com> <17d8ddd76f7.d167f605179643.3635445903460764440@excalamus.com> <87bl1u49ru.fsf@tsdye.online> <17dcc5a0e3e.d8ca0ef6361712.4976360594738663013@excalamus.com> <875yr4iu3a.fsf@tsdye.online> <17e11edb77e.adb20ab5289948.958495178633735939@excalamus.com> Subject: Re: [PATCH] ob-shell-test, test-ob-shell and introduction MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Received-SPF: pass client-ip=136.143.188.14; envelope-from=matt@excalamus.com; helo=sender4-op-o14.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641440940; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=lPzIO6pfWPvaf8KLJShZ+ySrVGe0yGSUphPCRV+rZ7Q=; b=uscG3MluTNK7/bNip3qQ7Y6GZaydXyLGB/at8qDOc5ui6trXSp+pQUX1XzCyt6RpLxz9Ap TSqwGpp1P0YRBgFtDNXzufV1FruObLyJnTOgXsyzmB9X9F/r7b0FhdTTsGPfEeA0B4WjKE 5EzA1zSP6BwQO/4DbjecNdDEPrZ9XOmHb76Eq+WYIJjupcJUEot0c0TgRiFOvILfWKeq5O OFXfJ9RDufKXs4aQUW6UWzIg5oxC8NjjD6+8azekniJc228JbkmpMWy7H1eWjiY9eIAAYv b0hAmFUX/p/L9TjFXSZaiCnA7wu9WWp6kLQPXuEn+DWKJlFnd0EJcb+WFM8Ehg== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1641440940; a=rsa-sha256; cv=fail; b=gDFCvC5LITqCkEn+dU4G57yV+VIy3jR4O51nqP0z7Ei9pObiyG9jzqkerxaiUuaKWRlvyu mGJfTulofQh99gWGzupfiY4CW1KbywTaK8Mkp93uuSmOKOMpNswQKJn4oTaimzIq4hE5EI q1vdHWmPCzcyDNfwPjWPNWbm4jbWmvVEIII4FJTDoZjuVXmTmJ6h5vDLWkyf0d3hw0fTXy Q33runuThOcoOPn4umPGZIW5ktC+QTOE3pQKNMLTrFIiyUoojRihVbaa9BE6k4VrRQc4ti AFapLC32WeUNyrTk/PGCiQoB9obsYnUnK0GZLOEBMQdOnQ1dQI+4W0uocweTGQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=excalamus.com header.s=zmail header.b=GQq+xy9H; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.09 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=excalamus.com header.s=zmail header.b=GQq+xy9H; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 963923C36C X-Spam-Score: -1.09 X-Migadu-Scanner: scn1.migadu.com X-TUID: cAgcyf55peqj > Thank you, I was not aware of ":cmdline" argument and of ":shebang" as a= =20 > means to avoid stray prompts (I have seen mentions of similar problem=20 > for other languages in this list). =20 You're welcome! I was surprised to find those in the source. Glad to have d= ocumented them and even happier to hear that it's news to others. =20 > - https://www.mirbsd.org/pics/logo-grey.png works only with http:=20 > protocol for me. I updated (downgraded?) it to http. I'm also seeing that the kornshell log= o is intermittently broken. Not quite sure the best way to go about fixing= that. Maybe commit copies? Use something like archive.org? Sounds like = a problem for someone else (e.g. future me). I'm out of time for tonight. > - I am unsure concerning example after "=E2=80=A6or as a standlone scrip= t.",=20 > maybe it should be wrapped into #+begin_example. Good call. That example was wonky. I've given a different one. Not sure = it's better, though. I find the shebang behavior tricky to demo in a simpl= e way. > - In some cases "sh" is used despite bashisms in the code like "declare"= =20 > or "echo -ne". Actually "printf" may be more convenient instead of "echo= -n" > - "export" in session example is unnecessary. It is matter of taste=20 > though. Bash and dash is not the case, but some shells require that=20 > assignment and export should be separate commands. Good catch! Since arrays are only defined in ob-shell using bash, I've upd= ated that example to use bash. Otherwise, I've removed the exports.=20 > - In your examples variable values are simple. Often it is safer to add= =20 > double quotes around variable or command expansion. I would consider=20 > adding quotes just to encourage people to do the same by default with=20 > hope that less scripts will give strange results in response to a file= =20 > name containing a space. Actually my first impression was that=20 > backslashes before quotes in some cases were added by mistake. Another= =20 > unescaped pair of quotes may make your intention more clear. However it= =20 > is related to code style where everybody has opinion, so I do not insist= . I appreciate these clarifications. Admittedly, I'm not great with shell scr= ipting. Your recommendations appear sound to me and I've tried to incorpor= ate them. The updates have been made and are pushed. Thanks for your feedback!